From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id EDA623858291; Thu, 30 Mar 2023 16:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDA623858291 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x433.google.com with SMTP id u38so12843763pfg.10; Thu, 30 Mar 2023 09:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680192104; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=str7/pOQ95f2d/sabdAIO++j12FFa+RPwyQf9VV9suI=; b=CPvz7puJwH5lhmNM+XnH+nhWdsHAS0bjUOm/8Kx69uHT1CLRDbXvARV7+DEY9w2bj1 CdZLLQsrYhq+VZi6PIH+HAKuWwjNX7LgERls+9Kz57eu50JrdSRXRBLObWQwGYuzSNb6 bdOu7pl6lJph1ETDq/7uZVqdLwveu2xvkIH9u4blbAzal0BYWgykgVKiBfgvOfMHknbj lXFkBp4rvMiOv6FTLbNBh0C/K+F6gvm0xpqqs6mLdWPNSWTYc9ClY8OTHtScgbugkpMj Ih4oSzgqOHWO2xVwM2LgJhto3zVdtSnNA9go788oPJhCw+LM3qvi+vjTaXfiySWvqzzt jCiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680192104; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=str7/pOQ95f2d/sabdAIO++j12FFa+RPwyQf9VV9suI=; b=Qx9nMdG69EWWXxEdBwaTIANd1wO3ny0jTAbLFOmtUoW+4jQEYz2YD6R8ULyi01zd2t RUAgSAwAG8yfLzRzwgWgJiQvNH1OfafQ9pyFbsmuCSJaVjnAR+q/6GfZe1symBjWDKuK M7ck5oKiGxi4v5xHKW+a7mEy/fLbTybdhLiSP4GJjTwyivxdqysy5JdLEZDdS2AtJSEj 6xdVYyAthk6SVlENPSEImvcmoTSy+7oTmf8B5+tk3p3Ewtugst5PPgNt93uRa0wbz15+ MCXGgakqsJtY0XwvI33CYgVRqcwhYBq9YJyI8kvy/IfRuf3l2GmhiKDvAWzcmQgkxD6R x6kQ== X-Gm-Message-State: AAQBX9dHYspQayajYi8bG0e6bMKH5/mToa2IR/ZxpsLcfseOIoOfxkTy TthC8+Iicjxyh1Qvg3UZJ8xZkJmbxBa+ytVNlzs= X-Google-Smtp-Source: AKy350Y7oldeb5QHzxrFS508/aUFI+/qZWjpFqgQehT3Iuopva8FqYMiHA2Nt9RmwaZl86BJjPnhfIgC5kDD0NsBGqQ= X-Received: by 2002:a63:6781:0:b0:513:25c1:7c68 with SMTP id b123-20020a636781000000b0051325c17c68mr6351167pgc.5.1680192103767; Thu, 30 Mar 2023 09:01:43 -0700 (PDT) MIME-Version: 1.0 References: <20230329234000.1405216-1-jwakely@redhat.com> In-Reply-To: From: =?UTF-8?Q?Daniel_Kr=C3=BCgler?= Date: Thu, 30 Mar 2023 18:01:32 +0200 Message-ID: Subject: Re: [committed] libstdc++: Fix constexpr functions in To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Do., 30. M=C3=A4rz 2023 um 18:00 Uhr schrieb Jonathan Wakely via Libstdc++ : > [..] > > In fact, thinking about P2641 some more, I might revert this change. > Instead of adding an extra bool member to support constexpr, I think > I'll just remove the 'constexpr' keywords from basic_endpoint for now, > and implement it in terms of just inspecting the sa_family_t member of > the union members. And then later, once we have something like P2641, > we can re-add the constexpr keywords and use is_within_lifetime during > constant evaluation. That way we don't add a bool then need to take it > away again, changing the ABI each time. I was just going to make the same suggestion. - Daniel