From: "Daniel Krügler" <daniel.kruegler@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Add missing __cpp_lib_format macro to <version>
Date: Wed, 22 Mar 2023 18:58:50 +0100 [thread overview]
Message-ID: <CAGNvRgAzRDHy0C_peL_P-FMMm4F_qpExzCuttXPsiM+9gsBemw@mail.gmail.com> (raw)
In-Reply-To: <20230322175003.408005-1-jwakely@redhat.com>
Am Mi., 22. März 2023 um 18:53 Uhr schrieb Jonathan Wakely via
Libstdc++ <libstdc++@gcc.gnu.org>:
>
> Tested powerpc64le-linux, pushed to trunk.
>
> -- >8--
>
> libstdc++-v3/ChangeLog:
>
> * include/std/version (__cpp_lib_format): Define.
> * testsuite/std/format/functions/format.cc: Check it.
> ---
> libstdc++-v3/include/std/version | 1 +
> .../testsuite/std/format/functions/format.cc | 15 +++++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/libstdc++-v3/include/std/version b/libstdc++-v3/include/std/version
> index 25ebfc3e512..a19c39c6cdd 100644
> --- a/libstdc++-v3/include/std/version
> +++ b/libstdc++-v3/include/std/version
> @@ -277,6 +277,7 @@
> #define __cpp_lib_constexpr_utility 201811L
> #define __cpp_lib_constexpr_vector 201907L
> #define __cpp_lib_erase_if 202002L
> +#define __cpp_lib_format 202106L
Shouldn't the value be 202207L? (This of-course of your conforming completeness)
Thanks,
- Daniel
next prev parent reply other threads:[~2023-03-22 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 17:50 Jonathan Wakely
2023-03-22 17:58 ` Daniel Krügler [this message]
2023-03-22 19:46 ` Jonathan Wakely
2023-03-22 19:53 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGNvRgAzRDHy0C_peL_P-FMMm4F_qpExzCuttXPsiM+9gsBemw@mail.gmail.com \
--to=daniel.kruegler@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).