From: "Daniel Krügler" <daniel.kruegler@gmail.com>
To: Tim Song <t.canens.cpp@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] Inline Variables for the Standard Library (p0607r0)
Date: Sat, 11 Mar 2017 20:37:00 -0000 [thread overview]
Message-ID: <CAGNvRgBu-hPJO2FYJrY97Zfn0Nzg8MqOH+qRiMkQE1V_8M2taA@mail.gmail.com> (raw)
In-Reply-To: <CAPQZVxt_yMDDvn3CNHav1EX7VJTf9ODUdAipVSEqBD7LN7_Puw@mail.gmail.com>
2017-03-11 21:23 GMT+01:00 Tim Song <t.canens.cpp@gmail.com>:
> On Sat, Mar 11, 2017 at 1:32 PM, Daniel Krügler
> <daniel.kruegler@gmail.com> wrote:
>> This patch applies inline to all namespace scope const variables
>> according to options A and B2 voted in during the Kona meeting, see:
>>
>> http://wiki.edg.com/pub/Wg21kona2017/StrawPolls/p0607r0.html
>>
>> During that work it has been found that std::ignore was not declared
>> constexpr (http://cplusplus.github.io/LWG/lwg-defects.html#2773),
>> which was fixed as well.
>
> Just adding constexpr to std::ignore does ~nothing. The assignment
> operator needs to be made constexpr too; there is really no other
> reason to use std::ignore.
There is nothing in the resolution of the issue (Nor in the discussion
that argues for the change) that says so. Yes, I considered to make
the assignment function template constexpr, but decided against it,
because the wording of the issue doesn't have this requirement). I'm
also aware of a test-case which would show the difference, but again:
This was not what the issue said. In fact I'm in the process to open a
new library issue that should impose that additional requirement.
- Daniel
next prev parent reply other threads:[~2017-03-11 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 18:27 Daniel Krügler
[not found] ` <CAGNvRgCpc9J81-aTTNQWNQws9ixqzq_pcMnrbk6nf6L-jAQoAA@mail.gmail.com>
2017-03-11 20:24 ` Tim Song
2017-03-11 20:37 ` Daniel Krügler [this message]
2017-03-11 22:10 ` Tim Song
2017-03-11 22:15 ` Daniel Krügler
2017-03-12 0:04 ` Daniel Krügler
2017-03-21 21:26 ` Daniel Krügler
2017-03-23 17:47 ` Jonathan Wakely
2017-03-23 17:49 ` Tim Song
2017-03-23 18:13 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGNvRgBu-hPJO2FYJrY97Zfn0Nzg8MqOH+qRiMkQE1V_8M2taA@mail.gmail.com \
--to=daniel.kruegler@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=t.canens.cpp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).