From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-503007-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 100682 invoked by alias); 15 Jun 2019 10:53:02 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 100667 invoked by uid 89); 15 Jun 2019 10:53:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail-lf1-f49.google.com
Received: from mail-lf1-f49.google.com (HELO mail-lf1-f49.google.com) (209.85.167.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Jun 2019 10:53:00 +0000
Received: by mail-lf1-f49.google.com with SMTP id z15so3369995lfh.13;        Sat, 15 Jun 2019 03:53:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=vg6JXdLByg+wPSWyTosHPfdwE3QEVEF56nXikPTw5KM=;        b=BSc3id0JZlMVJrn6Jwj340+fQTprDtvkjO4O/dmFRg8bgyy6ajW0l195WF/l3Nnopz         bgWxYXAuxmDGRXkTeZUIzOg4Jg6+ZwgJ9x2SgSBmomGMkWBFVotzkGgO9RtjX1bu3gad         qhIJ/7DztJtH73LBukySLcSGr1rRtnGT+AcnXwR0VVMj4ZzIeDix0EhyW7OOrGIHYMPI         zCs4fGzBz6LZmvVv9/JmHSlnhASnMkp/p8D4P0WeueM8OoevZk38SXMXt6wICRClphPK         JNf6pzsrD8TTpyYdOGwBuYrwMwwBGu18CbCKHse9F0RPSVSLuUc7rxuVN9Pe1SqEMi07         EQng==
MIME-Version: 1.0
References: <20190614140507.GA24550@redhat.com>
In-Reply-To: <20190614140507.GA24550@redhat.com>
From: =?UTF-8?Q?Daniel_Kr=C3=BCgler?= <daniel.kruegler@gmail.com>
Date: Sat, 15 Jun 2019 10:53:00 -0000
Message-ID: <CAGNvRgCo6E55FGHXgQLqU+7cMpyLX1QxUw1pWaOQ3CcZFF1Zfw@mail.gmail.com>
Subject: Re: [PATCH] Disable -Wctor-dtor-privacy warnings for some standard types
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>, gcc-patches List <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2019-06/txt/msg00874.txt.bz2

Am Fr., 14. Juni 2019 um 16:05 Uhr schrieb Jonathan Wakely <jwakely@redhat.com>:
>
> These types are not constructible by design, so we never want warnings
> for them, even with -Wsystem-headers.
>
>         * include/experimental/type_traits (experimental::nonesuch): Use
>         pragma to disable -Wctor-dtor-privacy warnings.
>         * include/std/type_traits (__is_convertible_helper<From, To, false>)
>         (__is_nt_convertible_helper<From, To, false>, __nonesuch): Likewise.
>
> Tested x86_64-linux, committed to trunk.

Unless I'm misunderstanding something, __nonesuchbase (twice) would
not be affected by that warning, so maybe the start of the
corresponding warning suppression could be moved after their
definition? Or did you do it that way to keep __nonesuchbase and
nonesuch close together?

- Daniel