From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13685 invoked by alias); 3 Dec 2012 11:42:22 -0000 Received: (qmail 13676 invoked by uid 22791); 3 Dec 2012 11:42:21 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_KC,TW_LV X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 11:42:13 +0000 Received: by mail-lb0-f175.google.com with SMTP id gg13so2142099lbb.20 for ; Mon, 03 Dec 2012 03:42:12 -0800 (PST) Received: by 10.112.28.133 with SMTP id b5mr4262982lbh.79.1354534931947; Mon, 03 Dec 2012 03:42:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.135.105 with HTTP; Mon, 3 Dec 2012 03:41:51 -0800 (PST) In-Reply-To: <20121203110534.GS2315@tucnak.redhat.com> References: <20121130101420.GE2315@tucnak.redhat.com> <20121130144602.GF2315@tucnak.redhat.com> <20121130155932.GG2315@tucnak.redhat.com> <20121130162525.GH2315@tucnak.redhat.com> <20121203091815.GP2315@tucnak.redhat.com> <20121203110534.GS2315@tucnak.redhat.com> From: Konstantin Serebryany Date: Mon, 03 Dec 2012 11:42:00 -0000 Message-ID: Subject: Re: [PATCH] asan_test.cc from llvm To: Jakub Jelinek Cc: Ian Lance Taylor , Dodji Seketeli , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00110.txt.bz2 On Mon, Dec 3, 2012 at 3:05 PM, Jakub Jelinek wrote: > On Mon, Dec 03, 2012 at 01:51:50PM +0400, Konstantin Serebryany wrote: >> > I'm attaching the diff for asan_test.cc from llvm anyway. >> > >> >> I see #ifdef ASAN_AVOID_EXPENSIVE_TESTS, which I don't really like >> >> because I'd rather fix the test than disable it. >> > >> > The test isn't disabled, just by default limited to 30 threads instead of >> > 1000, because that really will ruin testing for everybody with ulimit -u >> > in 1024-ish range. Even 500 threads would be undesirable for that. >> >> Which is the same as disabling it. >> Unfortunately, we don't have a good automated way to test asan performance, >> so this test is guarding us from performance degradation in the asan's >> pthread wrappers. > > I understand that, that is why the test by default, when not run as part of > dejagnu, or even in dejagnu when requested expensive tests, runs 1000 > threads instead of 30. > >> Anyway, does http://llvm.org/viewvc/llvm-project?rev=169118&view=rev >> solve the problem? >> It adds ASAN_AVOID_EXPENSIVE_TESTS and checks the results of all >> pthread_{create,join} calls in tests. > > Yes, thanks. So, is the patch ok to commit to GCC with the imported tests remerged > from upstream Yes, ok to commit. Thanks! --kcc > (or do I need to repost the patch for that)? > > Jakub