From: "augustine.sterling@gmail.com" <augustine.sterling@gmail.com>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: Jan Hubicka <hubicka@ucw.cz>, Jan Hubicka <jh@suse.cz>,
gcc-patches@gcc.gnu.org
Subject: Re: [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string)
Date: Thu, 10 Jul 2014 14:41:00 -0000 [thread overview]
Message-ID: <CAGSvup8Yk1FfSunyUxbbsGVSZ82cVvR5o82qjPDXfguoVm_zOg@mail.gmail.com> (raw)
In-Reply-To: <20140704211130.GK28529@lug-owl.de>
On Fri, Jul 4, 2014 at 2:11 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Wed, 2014-06-25 08:55:57 -0700, augustine.sterling@gmail.com <augustine.sterling@gmail.com> wrote:
>> On Tue, Jun 24, 2014 at 10:20 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> > > This is the xtensa fallout, see http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272418
>> > >
>> > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o insn-preds.o -MT insn-preds.o -MMD -MP -MF ./.deps/insn-preds.TPo insn-preds.c
>> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md: In function ‘int call_insn_operand_1(rtx, machine_mode)’:
>> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:113:57: error: cannot convert ‘const char*’ to ‘tree’ in assignment
>> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:119:46: error: cannot convert ‘const char*’ to ‘tree’ in assignment
>> > > make[1]: *** [insn-preds.o] Error 1
>> > Should be fixed by this (and I see in my prevoius mail I wanted TREE_STRING_POINTER)
>>
>> [resend due to gmail's stupid html-by-default]
>>
>> This patch looks correct to me, but I haven't watched quite enough of
>> the underlying change to know that replacing the strcmp with pointer
>> equality is really the right thing.
>>
>> If it is, approved for Xtensa.
>
> *ping*
>
> As Jan wrote it, I *guess* it probably is (haven't checked.)
Approved.
next prev parent reply other threads:[~2014-07-10 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 4:33 Turn DECL_SECTION_NAME into string Jan Hubicka
2014-06-12 7:52 ` Richard Biener
2014-06-12 8:13 ` Jan Hubicka
2014-06-17 6:40 ` Thomas Schwinge
2014-06-17 8:19 ` Richard Biener
2014-06-25 1:12 ` [BUILDROBOT] v850 fallout (was: Turn DECL_SECTION_NAME into string) Jan-Benedict Glaw
2014-06-25 5:18 ` Jan Hubicka
2014-06-25 9:21 ` [BUILDROBOT] v850 fallout Nicholas Clifton
2014-06-25 1:16 ` [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string) Jan-Benedict Glaw
2014-06-25 5:20 ` Jan Hubicka
2014-06-25 15:56 ` augustine.sterling
2014-07-04 21:11 ` Jan-Benedict Glaw
2014-07-10 14:41 ` augustine.sterling [this message]
2014-06-25 1:23 ` [BUILDROBOT] frv " Jan-Benedict Glaw
2014-06-25 5:23 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGSvup8Yk1FfSunyUxbbsGVSZ82cVvR5o82qjPDXfguoVm_zOg@mail.gmail.com \
--to=augustine.sterling@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jbglaw@lug-owl.de \
--cc=jh@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).