From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9816 invoked by alias); 10 Jul 2014 14:41:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9793 invoked by uid 89); 10 Jul 2014 14:41:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f178.google.com Received: from mail-qc0-f178.google.com (HELO mail-qc0-f178.google.com) (209.85.216.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 10 Jul 2014 14:41:42 +0000 Received: by mail-qc0-f178.google.com with SMTP id i17so3654237qcy.9 for ; Thu, 10 Jul 2014 07:41:40 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.47.173 with SMTP id m42mr78592519qga.9.1405003299820; Thu, 10 Jul 2014 07:41:39 -0700 (PDT) Received: by 10.229.245.194 with HTTP; Thu, 10 Jul 2014 07:41:39 -0700 (PDT) In-Reply-To: <20140704211130.GK28529@lug-owl.de> References: <20140612043325.GA6864@kam.mff.cuni.cz> <20140625011651.GN31494@lug-owl.de> <20140625052053.GD30367@kam.mff.cuni.cz> <20140704211130.GK28529@lug-owl.de> Date: Thu, 10 Jul 2014 14:41:00 -0000 Message-ID: Subject: Re: [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string) From: "augustine.sterling@gmail.com" To: Jan-Benedict Glaw Cc: Jan Hubicka , Jan Hubicka , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-07/txt/msg00713.txt.bz2 On Fri, Jul 4, 2014 at 2:11 PM, Jan-Benedict Glaw wrote: > On Wed, 2014-06-25 08:55:57 -0700, augustine.sterling@gmail.com wrote: >> On Tue, Jun 24, 2014 at 10:20 PM, Jan Hubicka wrote: >> > > This is the xtensa fallout, see http://toolchain.lug-owl.de/buildbot= /show_build_details.php?id=3D272418 >> > > >> > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptio= ns -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-s= trings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedanti= c -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common = -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/g= cc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/g= cc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/= jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/r= epos/gcc/gcc/../libbacktrace -o insn-preds.o -MT insn-preds.o -MMD -MP -= MF ./.deps/insn-preds.TPo insn-preds.c >> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md: In function = =E2=80=98int call_insn_operand_1(rtx, machine_mode)=E2=80=99: >> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:113:57: error= : cannot convert =E2=80=98const char*=E2=80=99 to =E2=80=98tree=E2=80=99 in= assignment >> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:119:46: error= : cannot convert =E2=80=98const char*=E2=80=99 to =E2=80=98tree=E2=80=99 in= assignment >> > > make[1]: *** [insn-preds.o] Error 1 >> > Should be fixed by this (and I see in my prevoius mail I wanted TREE_S= TRING_POINTER) >> >> [resend due to gmail's stupid html-by-default] >> >> This patch looks correct to me, but I haven't watched quite enough of >> the underlying change to know that replacing the strcmp with pointer >> equality is really the right thing. >> >> If it is, approved for Xtensa. > > *ping* > > As Jan wrote it, I *guess* it probably is (haven't checked.) Approved.