From: David Edelsohn <dje.gcc@gmail.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Steve Munroe <sjmunroe@us.ibm.com>
Subject: Re: [PATCH] PR target/65849 -- Add additional options to powerpc #pragma/attribute target support
Date: Fri, 24 Apr 2015 13:51:00 -0000 [thread overview]
Message-ID: <CAGWvny=-RykJ=quu+N_op7hmvXQ6H0Xq+zuKSH19n9LzQrqMfQ@mail.gmail.com> (raw)
In-Reply-To: <20150423192515.GA9236@ibm-tiger.the-meissners.org>
On Thu, Apr 23, 2015 at 3:25 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> Steve Munroe was tuning an application on PowerPC, and needed to set the
> -msave-toc-indirect option for only one function, and it wasn't available via
> the #praga/attribute target options. This patch adds support for the
> additional options that don't involve an ABI change to the list of options that
> can be set via the #pragma GCC target or attribute((target(...))) support.
>
> I have bootstrapped the compiler on a power7 (big endian) and power8 (little
> endian) with no regressions. Is this patch ok to install? I would like to
> backport this patch to the current branches (5.x, 4.9, 4.8, maybe 4.7). Is
> this ok?
>
> [gcc]
> 2015-04-23 Michael Meissner <meissner@linux.vnet.ibm.com>
>
> PR target/65849
> * config/rs6000/rs6000.opt (-mvsx-align-128): Make options that
> save to independent variables use the Save attribute. This will
> allow these options to be modified with the #pragma/attribute
> target support.
> (-mallow-movmisalign): Likewise.
> (-mallow-df-permute): Likewise.
> (-msched-groups): Likewise.
> (-malways-hint): Likewise.
> (-malign-branch-targets): Likewise.
> (-mvectorize-builtins): Likewise.
> (-msave-toc-indirect): Likewise.
>
> * config/rs6000/rs6000.c (rs6000_opt_masks): Add more options that
> can be set via the #pragma/attribute target support.
> (rs6000_opt_vars): Likewise.
> (rs6000_inner_target_options): If VSX was set, also set
> -mno-avoid-indexed-addresses.
>
> [gcc/testsuite]
> 2015-04-23 Michael Meissner <meissner@linux.vnet.ibm.com>
>
> PR target/65849
> * gcc.target/powerpc/pr65849-1.c: New test to verify being able to
> set new options.
> * gcc.target/powerpc/pr65849-2.c: Likewise.
Okay.
Thanks, David
prev parent reply other threads:[~2015-04-24 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 19:25 Michael Meissner
2015-04-24 13:51 ` David Edelsohn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=-RykJ=quu+N_op7hmvXQ6H0Xq+zuKSH19n9LzQrqMfQ@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
--cc=sjmunroe@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).