From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9908 invoked by alias); 24 Apr 2015 13:51:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9894 invoked by uid 89); 24 Apr 2015 13:51:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f169.google.com Received: from mail-ie0-f169.google.com (HELO mail-ie0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 24 Apr 2015 13:51:21 +0000 Received: by iecrt8 with SMTP id rt8so83785691iec.0 for ; Fri, 24 Apr 2015 06:51:19 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.107.33.21 with SMTP id h21mr11222728ioh.1.1429883479741; Fri, 24 Apr 2015 06:51:19 -0700 (PDT) Received: by 10.36.108.21 with HTTP; Fri, 24 Apr 2015 06:51:19 -0700 (PDT) In-Reply-To: <20150423192515.GA9236@ibm-tiger.the-meissners.org> References: <20150423192515.GA9236@ibm-tiger.the-meissners.org> Date: Fri, 24 Apr 2015 13:51:00 -0000 Message-ID: Subject: Re: [PATCH] PR target/65849 -- Add additional options to powerpc #pragma/attribute target support From: David Edelsohn To: Michael Meissner , GCC Patches , Steve Munroe Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2015-04/txt/msg01507.txt.bz2 On Thu, Apr 23, 2015 at 3:25 PM, Michael Meissner wrote: > Steve Munroe was tuning an application on PowerPC, and needed to set the > -msave-toc-indirect option for only one function, and it wasn't available via > the #praga/attribute target options. This patch adds support for the > additional options that don't involve an ABI change to the list of options that > can be set via the #pragma GCC target or attribute((target(...))) support. > > I have bootstrapped the compiler on a power7 (big endian) and power8 (little > endian) with no regressions. Is this patch ok to install? I would like to > backport this patch to the current branches (5.x, 4.9, 4.8, maybe 4.7). Is > this ok? > > [gcc] > 2015-04-23 Michael Meissner > > PR target/65849 > * config/rs6000/rs6000.opt (-mvsx-align-128): Make options that > save to independent variables use the Save attribute. This will > allow these options to be modified with the #pragma/attribute > target support. > (-mallow-movmisalign): Likewise. > (-mallow-df-permute): Likewise. > (-msched-groups): Likewise. > (-malways-hint): Likewise. > (-malign-branch-targets): Likewise. > (-mvectorize-builtins): Likewise. > (-msave-toc-indirect): Likewise. > > * config/rs6000/rs6000.c (rs6000_opt_masks): Add more options that > can be set via the #pragma/attribute target support. > (rs6000_opt_vars): Likewise. > (rs6000_inner_target_options): If VSX was set, also set > -mno-avoid-indexed-addresses. > > [gcc/testsuite] > 2015-04-23 Michael Meissner > > PR target/65849 > * gcc.target/powerpc/pr65849-1.c: New test to verify being able to > set new options. > * gcc.target/powerpc/pr65849-2.c: Likewise. Okay. Thanks, David