From: David Edelsohn <dje.gcc@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Bill Schmidt <wschmidt@linux.vnet.ibm.com>,
Jonathan Wakely <jwakely@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH, rs6000, libstdc++] Add baseline_symbols.txt for powerpc64le-linux-gnu
Date: Tue, 07 Apr 2015 13:49:00 -0000 [thread overview]
Message-ID: <CAGWvny=7aFTB8JSGTMOa01q6D=FMiAYHRnqbzM33vZ+Vz2FQyw@mail.gmail.com> (raw)
In-Reply-To: <20150407134538.GF19273@tucnak.redhat.com>
On Tue, Apr 7, 2015 at 9:45 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Apr 07, 2015 at 08:39:37AM -0500, Bill Schmidt wrote:
>> Posted below the differences from powerpc64-linux-gnu. A surprising
>> number of additional symbols, but none are missing in the new baseline.
>> (Perhaps powerpc64-linux-gnu needs updating?)
>
> Sure, it needs updating.
>
> So, if I filter the GLIBCXX_3.4.21 and CXXABI_1.3.9 symbols from your diff,
> I get
> grep -v '@@GLIBCXX_3.4.21\|@@CXXABI_1.3.9' /tmp/XX | grep @
>> TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
>> TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>
> which are the two lines you should manually remove.
> But then, it means the powerpc64-linux-gnu and powerpc64le-linux-gnu
> baseline_symbols.txt are identical, so the question is if we really need
> to duplicate it, instead of just telling in the configury that for
> powerpc64le-linux-gnu it should use the powerpc64-linux-gnu
> baseline_symbols.txt.
I thought that they are using the same baseline_symbols.txt at the
moment and Bill's patch explicitly separates them in configure. If
the files are identical, then no need to separate them and no need for
the patch. If/when they diverge for a good reason (IEEE long
double?), we can revisit the patch.
Thanks, David
next prev parent reply other threads:[~2015-04-07 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 2:31 Bill Schmidt
2015-04-07 13:09 ` Jakub Jelinek
2015-04-07 13:19 ` Jonathan Wakely
2015-04-07 13:40 ` Bill Schmidt
2015-04-07 13:45 ` Jakub Jelinek
2015-04-07 13:49 ` David Edelsohn [this message]
2015-04-07 13:54 ` Bill Schmidt
[not found] <1428368093.2816.51.camel@gnopaine>
2015-04-07 13:03 ` David Edelsohn
2015-04-07 13:41 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=7aFTB8JSGTMOa01q6D=FMiAYHRnqbzM33vZ+Vz2FQyw@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).