public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: Caroline Tice <cmtice@google.com>
Cc: Jeffrey Law <law@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)
Date: Tue, 28 Apr 2015 17:14:00 -0000	[thread overview]
Message-ID: <CAGWvny=Ezy9MqJ1p_y4hbdnzHMQ6cHijPxZ7PPPAeE5_K=74rw@mail.gmail.com> (raw)

Caroline,

Your patch has broken bootstrap on AIX and probably other platforms.

/nasfarm/edelsohn/src/src/gcc/varasm.c: In function 'void
assemble_end_function(tree, const char*)':
/nasfarm/edelsohn/src/src/gcc/varasm.c:1870:12: error:
'ASM_DECLARE_FUNCTION_SIZE' was not declared in this scope
        decl);
            ^

You added a reference to ASM_DECLARE_FUNCTION_SIZE without guarding
it, as was done only 10 lines higher in the same function.  The macro
is not declared for all targets.

Also, the ChangeLog entry has numerous typos.

Please fix ASAP.

Thanks, David

             reply	other threads:[~2015-04-28 17:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 17:14 David Edelsohn [this message]
2015-04-28 17:15 ` Caroline Tice
2015-04-28 17:16   ` Jeff Law
2015-04-28 17:17   ` Gerald Pfeifer
2015-04-28 17:33   ` David Edelsohn
2015-04-28 17:36     ` Caroline Tice
  -- strict thread matches above, loose matches on Subject: below --
2015-04-29 16:48 Uros Bizjak
2015-04-29 17:57 ` Caroline Tice
2015-04-29 18:12   ` Uros Bizjak
2015-04-29 18:52     ` Uros Bizjak
2015-04-29 19:08       ` Caroline Tice
2015-04-29 21:30         ` Caroline Tice
2015-04-30  4:15           ` Jack Howarth
2015-04-30  6:40           ` Uros Bizjak
2015-04-30 16:36             ` Caroline Tice
2015-04-30 17:32               ` Uros Bizjak
2015-04-30 17:44               ` Richard Henderson
2015-04-30 19:34                 ` H.J. Lu
2015-04-30 19:34                   ` Caroline Tice
2015-04-30 19:38                     ` Uros Bizjak
2015-04-30 19:42                     ` H.J. Lu
2014-12-05 22:41 Caroline Tice
2014-12-08 21:07 ` Jeff Law
2015-03-27 16:45   ` Caroline Tice
2015-03-31  5:19     ` Jeff Law
2015-03-31 15:13       ` Caroline Tice
2015-03-31 15:17         ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWvny=Ezy9MqJ1p_y4hbdnzHMQ6cHijPxZ7PPPAeE5_K=74rw@mail.gmail.com' \
    --to=dje.gcc@gmail.com \
    --cc=cmtice@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).