From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11893 invoked by alias); 1 Aug 2014 03:28:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11825 invoked by uid 89); 1 Aug 2014 03:28:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f171.google.com Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 01 Aug 2014 03:28:37 +0000 Received: by mail-vc0-f171.google.com with SMTP id hq11so5760044vcb.2 for ; Thu, 31 Jul 2014 20:28:35 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.52.73.2 with SMTP id h2mr554461vdv.76.1406863715111; Thu, 31 Jul 2014 20:28:35 -0700 (PDT) Received: by 10.220.11.5 with HTTP; Thu, 31 Jul 2014 20:28:34 -0700 (PDT) In-Reply-To: References: Date: Fri, 01 Aug 2014 03:28:00 -0000 Message-ID: Subject: Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV From: David Edelsohn To: Adhemerval Zanella , Richard Henderson , "Myers, Joseph" Cc: GCC Patches Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2014-08/txt/msg00006.txt.bz2 Thanks for implementing the FENV support. The patch generally looks good to me. My one concern is a detail in the implementation of "update". I do not have enough experience with GENERIC to verify the details and it seems like it is missing building an outer COMPOUND_EXPR containing update_mffs and the CALL_EXPR for update mtfsf. I would like someone to double check. Thanks, David