From: David Edelsohn <dje.gcc@gmail.com>
To: "CHIGOT, CLEMENT" <clement.chigot@atos.net>,
David Malcolm <dmalcolm@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] aix: handle 64bit inodes for include directories
Date: Sat, 22 May 2021 19:42:54 -0400 [thread overview]
Message-ID: <CAGWvny=QtwsqwPznCfAWpnPQg9OiKiyfRsmNex-pjXJtj5P9YQ@mail.gmail.com> (raw)
In-Reply-To: <CAGWvny=mgU-96zNzKq4-AF3YnCCp0suWOpmtSgR6piSzioAiGQ@mail.gmail.com>
+DavidMalcolm
Can you review this patch when you have a moment?
Thanks, David
On Mon, May 17, 2021 at 3:05 PM David Edelsohn <dje.gcc@gmail.com> wrote:
>
> The aix.h change is okay with me, but you need to get approval for the
> incpath.c and cpplib.h parts of the patch from the appropriate
> maintainers.
>
> Thanks, David
>
> On Mon, May 17, 2021 at 7:44 AM CHIGOT, CLEMENT <clement.chigot@atos.net> wrote:
> >
> > On AIX, stat will store inodes in 32bit even when using LARGE_FILES.
> > If the inode is larger, it will return -1 in st_ino.
> > Thus, in incpath.c when comparing include directories, if several
> > of them have 64bit inodes, they will be considered as duplicated.
> >
> > gcc/ChangeLog:
> > 2021-05-06 Clément Chigot <clement.chigot@atos.net>
> >
> > * configure.ac: Check sizeof ino_t and dev_t.
> > * config.in: Regenerate.
> > * configure: Regenerate.
> > * config/rs6000/aix.h (HOST_STAT_FOR_64BIT_INODES): New define.
> > * incpath.c (HOST_STAT_FOR_64BIT_INODES): New define.
> > (remove_duplicates): Use it.
> >
> > libcpp/ChangeLog:
> > 2021-05-06 Clément Chigot <clement.chigot@atos.net>
> >
> > * configure.ac: Check sizeof ino_t and dev_t.
> > * config.in: Regenerate.
> > * configure: Regenerate.
> > * include/cpplib.h (INO_T_CPP): Change for AIX.
> > (DEV_T_CPP): New macro.
> > (struct cpp_dir): Use it.
> >
> >
> >
next prev parent reply other threads:[~2021-05-22 23:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 11:44 CHIGOT, CLEMENT
2021-05-17 19:05 ` David Edelsohn
2021-05-22 23:42 ` David Edelsohn [this message]
2021-06-23 6:53 ` CHIGOT, CLEMENT
2021-06-24 19:17 ` Jeff Law
2021-06-28 7:16 ` CHIGOT, CLEMENT
2021-08-11 11:48 ` CHIGOT, CLEMENT
2021-08-19 18:23 ` Jeff Law
2021-08-24 7:57 ` CHIGOT, CLEMENT
2021-10-12 8:35 ` CHIGOT, CLEMENT
2021-10-26 14:51 ` CHIGOT, CLEMENT
2021-11-16 8:45 ` CHIGOT, CLEMENT
2021-12-30 16:43 ` David Edelsohn
2021-12-30 18:27 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=QtwsqwPznCfAWpnPQg9OiKiyfRsmNex-pjXJtj5P9YQ@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=clement.chigot@atos.net \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).