From: David Edelsohn <dje.gcc@gmail.com>
To: Richard Guenther <rguenther@suse.de>
Cc: Bruce Korb <bkorb@gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix bootstrap on OpenBSD, PR48851
Date: Mon, 04 Jul 2011 14:35:00 -0000 [thread overview]
Message-ID: <CAGWvny=R=3qnyeVeU35csUSQEZFcEw=vtSNqQXChWo3Kk1jxxw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1107041448470.810@zhemvz.fhfr.qr>
On Mon, Jul 4, 2011 at 8:51 AM, Richard Guenther <rguenther@suse.de> wrote:
> On Mon, 4 Jul 2011, Bruce Korb wrote:
>
>> Hi Richard,
>>
>> On Mon, Jul 4, 2011 at 4:04 AM, Richard Guenther <rguenther@suse.de> wrote:
>> >
>> > It happens that OpenBSD suffers from a bogus fixinclude that changes
>> > its perfectly valid NULL define from (void *)0 to 0. The fix itself
>> > appears to be very old and is completely bogus - it replaces
>> > (void *)0 with 0 under the assumption the former is invalid for C++ -
>> > which is true - but 0 is inappropriate for C which is much worse.
>> >
>> > Thus, I propose to remove the fix altogether. Platform maintainers
>> > can arrange for a new fix if the platforms still need fixing (which
>> > I seriously doubt after so many years and platform obsoletion).
>> >
>> > This restores bootstrap on OpenBSD.
>> >
>> > Ok for trunk and active branches?
>>
>> Sounds completely reasonable to me, but I think the platform maintainers
>> do need to say, "okay". Cheers - Bruce
>
> We do not have an Interix maintainer listed, that leaves David for AIX.
> David, is this ok? If not, can you please work on a better more
> specific fixinclude wrapping the C++ variant inside __GNUG__?
Okay with me.
Thanks, David
next prev parent reply other threads:[~2011-07-04 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 11:04 Richard Guenther
2011-07-04 12:46 ` Bruce Korb
2011-07-04 12:51 ` Richard Guenther
2011-07-04 14:35 ` David Edelsohn [this message]
2011-07-04 19:08 ` Mike Stump
2011-07-05 8:33 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=R=3qnyeVeU35csUSQEZFcEw=vtSNqQXChWo3Kk1jxxw@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=bkorb@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).