From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id B19A53858D28 for ; Tue, 10 Oct 2023 12:45:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B19A53858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-533c5d10dc7so9867590a12.3 for ; Tue, 10 Oct 2023 05:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696941905; x=1697546705; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x6Kxpk3bsWJYYMpPxGAN0Kv3z1NC48/j8Bz9GydnOL8=; b=EI0s/T7LDeRhF64buy/fOIrvRkEYafqUs7k2+yIGW0LUypz2ba3bB9lmD3dFwurePf qJP3ZYpemFR4f+kxHB8Hhnn8pWICFkSGEkKjGa3CsGDUWCvXc25+Hru5R1tyLDUXyXhN 3e5EIOKN3MRLUWsplwKaSCSazwfcqxzv8LV0IGLKW4vBT3eNtu7QnYQvw5PnpPrPCyQY uBQCvR3ohEykueg3W2Rd6VTMtIPpz30Zgl4Qv4tDkNgfeN6n4hKjoyznNQPJ+DxmtZAE QCDlZpdAcyov72PtJqKG/yFxKZQ8+iXpaVNJKjUJH7eoBZRc6HQFFdUGqujPZgGmshaQ VW8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696941905; x=1697546705; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x6Kxpk3bsWJYYMpPxGAN0Kv3z1NC48/j8Bz9GydnOL8=; b=flUemZN+Tk9mGM6eeTNxAixnWuypGpesqwA9H+Na9zkqzUHiqCuYwQAriYf1seyTcm TalBj111d8FOIyhgpsONPMwf8zWP2MCjPetNQGMLOGJcFQkSL21yYpDZodlSwV06ckqf /J0/VF1e1ztjZ1zHtAlRq6gcK7LzyDD0VEi1sRyhxlH3ub83gwsUfZJDqIeOggSw1G3v na3NNNEFu93nTPkwYBCWQLa9CiRAJxI40Gfp1AQIEpmtDmjyavxTPM6TAtU23PZoEAlk n2GkDZAXPH6DnO1zFMdjAHA3pUi7P27y6sTdtyfK2L9rQZ6A+cyjzc5f08S4fBzrKo9M Q/3Q== X-Gm-Message-State: AOJu0YxkSSrKqbEOP3RcK7523ZYRnw2i/XCwsNzFqg3E4MCFmoDNNveL pm9dRWFMYQHslLXztsJeh3NPvmPbXpHE8pX9rCg= X-Google-Smtp-Source: AGHT+IELIuPgqwF+gn+yHcE7PP0297FuBB8sNO6xW5bG9bqQ7lBsS5Heix4Tg9uej70AXxjpCU7fb5fNXnuH6faxNNc= X-Received: by 2002:a17:906:2098:b0:9ae:6196:a412 with SMTP id 24-20020a170906209800b009ae6196a412mr17050970ejq.69.1696941905223; Tue, 10 Oct 2023 05:45:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Edelsohn Date: Tue, 10 Oct 2023 08:44:53 -0400 Message-ID: Subject: Re: [PATCH-2, rs6000] Enable vector mode for memory equality compare [PR111449] To: HAO CHEN GUI Cc: gcc-patches , Segher Boessenkool , "Kewen.Lin" , Peter Bergner Content-Type: multipart/alternative; boundary="00000000000077273906075c13d1" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000077273906075c13d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 10, 2023 at 4:23=E2=80=AFAM HAO CHEN GUI wrote: > Hi David, > > Thanks for your review comments. > > =E5=9C=A8 2023/10/9 23:42, David Edelsohn =E5=86=99=E9=81=93: > > #define MOVE_MAX (! TARGET_POWERPC64 ? 4 : 8) > > #define MAX_MOVE_MAX 8 > > +#define MOVE_MAX_PIECES (!TARGET_POWERPC64 ? 4 : 16) > > +#define COMPARE_MAX_PIECES (!TARGET_POWERPC64 ? 4 : 16) > > > > > > How are the definitions of MOVE_MAX_PIECES and COMPARE_MAX_PIECES > determined? The email does not provide any explanation for the > implementation. The rest of the patch is related to vector support, but > vector support is not dependent on TARGET_POWERPC64. > > By default, MOVE_MAX_PIECES and COMPARE_MAX_PIECES is set the same value > as MOVE_MAX. The move and compare instructions are required in > compare_by_pieces, those macros are set to 16 byte when supporting > vector mode (V16QImode). The problem is rs6000 hasn't supported TImode > for "-m32". We discussed it in issue 1307. TImode will be used for > move when MOVE_MAX_PIECES is set to 16. But TImode isn't supported > with "-m32" which might cause ICE. > > So MOVE_MAX_PIECES and COMPARE_MAX_PIECES is set to 4 for 32 bit > target in this patch. They could be changed to 16 after rs6000 > supports TImode with "-m32". > Hi, Hao Thanks for the explanation. Are you stating that although PPC32 supports V16QImode in VSX, the move_by_pieces support also requires TImode, which is not available on PPC32? Thanks, David --00000000000077273906075c13d1--