From: David Edelsohn <dje.gcc@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Inline IBM long double __gcc_qsub
Date: Wed, 25 Aug 2021 20:23:32 -0400 [thread overview]
Message-ID: <CAGWvny=Xe8TXx1Z6QUABj85-UAjGrRDfUYJBdqQUR2Txp9gg3g@mail.gmail.com> (raw)
rs6000: inline ldouble __gcc_qsub
While performing some tests of IEEE 128 float for PPC64LE, Michael
Meissner noticed that __gcc_qsub is substantially slower than
__gcc_qadd. __gcc_qsub valls __gcc_add with the second operand
negated. Because the functions normally are invoked through
libgcc shared object, the extra PLT overhead has a large impact
on the overall time of the function. Instead of trying to be
fancy with function decorations to prevent interposition, this
patch inlines the definition of __gcc_qadd into __gcc_qsub with
the negation propagated through the function.
libgcc/ChangeLog:
* config/rs6000/ibm-ldouble.c (__gcc_qsub): Inline negated
__gcc_qadd.
diff --git a/libgcc/config/rs6000/ibm-ldouble.c
b/libgcc/config/rs6000/ibm-ldouble.c
index 4c13453f975..ed74900e5c3 100644
--- a/libgcc/config/rs6000/ibm-ldouble.c
+++ b/libgcc/config/rs6000/ibm-ldouble.c
@@ -158,9 +158,42 @@ __gcc_qadd (double a, double aa, double c, double cc)
}
IBM128_TYPE
-__gcc_qsub (double a, double b, double c, double d)
+__gcc_qsub (double a, double aa, double c, double cc)
{
- return __gcc_qadd (a, b, -c, -d);
+ double xh, xl, z, q, zz;
+
+ z = a - c;
+
+ if (nonfinite (z))
+ {
+ if (fabs (z) != inf())
+ return z;
+ z = -cc + aa - c + a;
+ if (nonfinite (z))
+ return z;
+ xh = z; /* Will always be DBL_MAX. */
+ zz = aa - cc;
+ if (fabs(a) > fabs(c))
+ xl = a - z - c + zz;
+ else
+ xl = -c - z + a + zz;
+ }
+ else
+ {
+ q = a - z;
+ zz = q - c + (a - (q + z)) + aa - cc;
+
+ /* Keep -0 result. */
+ if (zz == 0.0)
+ return z;
+
+ xh = z + zz;
+ if (nonfinite (xh))
+ return xh;
+
+ xl = z - xh + zz;
+ }
+ return pack_ldouble (xh, xl);
}
#ifdef __NO_FPRS__
next reply other threads:[~2021-08-26 0:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 0:23 David Edelsohn [this message]
2021-08-26 7:35 ` Andreas Schwab
2021-08-26 7:40 ` Andreas Schwab
2021-08-26 18:57 ` [PATCH v2] " David Edelsohn
2021-08-26 22:51 ` Segher Boessenkool
2021-08-26 23:07 ` David Edelsohn
2021-08-26 12:15 ` [PATCH] " Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=Xe8TXx1Z6QUABj85-UAjGrRDfUYJBdqQUR2Txp9gg3g@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).