From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dje.gcc@gmail.com>
Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com
 [IPv6:2607:f8b0:4864:20::e2d])
 by sourceware.org (Postfix) with ESMTPS id 4A464385840F;
 Fri,  3 Sep 2021 14:53:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A464385840F
Received: by mail-vs1-xe2d.google.com with SMTP id i23so4562609vsj.4;
 Fri, 03 Sep 2021 07:53:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=3ZySPp//8DiHfFgR3RQlWJlS9ryreOjbWalFrWmYHiE=;
 b=W045ZtzLqHfNXP6oYtuH5ifEdyn1XkBB+doON7+a6EpcnsHrCMTrhpWzgRWhu44pSH
 g4PptHsVItD4rMS+Ogf8tRGryw/tmKihX33ccv05vUPwPcvCJzLNS/fwmYC1f/tto9jS
 ggSVsCk0GNt+chMn4IqLPsY+anI65cfBnNhxd2BgaGQbFU/6P6oVsFDw0UGiOsKSggKK
 erxvOjcJATyGX6E3WOS/vDlaTrlBXWQyk9d7VzhXrT+fuv7pyMc8jMVSRmL0Q8eMyZvg
 ay+its/JYhqXnR06w86I4qFhr4UDH1e8gPAHXwyb/00QsA4RrOmS7TOXpXFYCj5r59yT
 kpVQ==
X-Gm-Message-State: AOAM5334DMVCm98CzcQiZiF0EvVAI/tgafSmxlWqKI7uEyNvwmxqp26Q
 i7gDvTd+flfJNdtV3V/0FuBLuXYoAWS98qtDRvk=
X-Google-Smtp-Source: ABdhPJz/m+yCIwsA5NvLHjg3or+rxzvEp7sdohIcS/RbRmhFp4FaAHAyUDwrN/1hXOqBd+OuO4WG4drKYH6mRT5Dngc=
X-Received: by 2002:a67:ef51:: with SMTP id k17mr2923844vsr.2.1630680805919;
 Fri, 03 Sep 2021 07:53:25 -0700 (PDT)
MIME-Version: 1.0
References: <20210416071007.78812-1-luoxhu@linux.ibm.com>
 <6d438971-4778-91cf-451c-a493b0cf9bdf@linux.ibm.com>
 <4ead69cf-daac-31bb-ddb5-d7b41cf298e2@linux.ibm.com>
 <ce4fcc41-f354-cba7-6ef4-74a5d9c0cfe3@linux.ibm.com>
 <cdefffe51ef4173a4c95c3ac077b27a20d099f07.camel@vnet.ibm.com>
 <2260972d-e44d-f084-69bb-2b7c96c00525@linux.ibm.com>
 <bb0d643d-9562-c53c-37da-9a110af421d1@linux.ibm.com>
In-Reply-To: <bb0d643d-9562-c53c-37da-9a110af421d1@linux.ibm.com>
From: David Edelsohn <dje.gcc@gmail.com>
Date: Fri, 3 Sep 2021 10:53:14 -0400
Message-ID: <CAGWvny=Z-MT9qhQx4tv6od5uCuu3q_i9USMz5SMMBvQEYeDUDA@mail.gmail.com>
Subject: Re: Ping ^ 2: [PATCH] rs6000: Expand fmod and remainder when built
 with fast-math [PR97142]
To: Xionghu Luo <luoxhu@linux.ibm.com>
Cc: will schmidt <will_schmidt@vnet.ibm.com>,
 GCC Patches <gcc-patches@gcc.gnu.org>, 
 Bill Schmidt <wschmidt@linux.ibm.com>,
 Segher Boessenkool <segher@kernel.crashing.org>, linkw@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Sep 2021 14:53:27 -0000

On Thu, Sep 2, 2021 at 10:31 PM Xionghu Luo <luoxhu@linux.ibm.com> wrote:
>
> Resend the patch that addressed Will's comments.
>
>
> fmod/fmodf and remainder/remainderf could be expanded instead of library
> call when fast-math build, which is much faster.
>
> fmodf:
>      fdivs   f0,f1,f2
>      friz    f0,f0
>      fnmsubs f1,f2,f0,f1
>
> remainderf:
>      fdivs   f0,f1,f2
>      frin    f0,f0
>      fnmsubs f1,f2,f0,f1
>
> SPEC2017 Ofast P8LE: 511.povray_r +1.14%,  526.blender_r +1.72%
>
> gcc/ChangeLog:
>
> 2021-09-03  Xionghu Luo  <luoxhu@linux.ibm.com>
>
>         PR target/97142
>         * config/rs6000/rs6000.md (fmod<mode>3): New define_expand.
>         (remainder<mode>3): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2021-09-03  Xionghu Luo  <luoxhu@linux.ibm.com>
>
>         PR target/97142
>         * gcc.target/powerpc/pr97142.c: New test.

Okay.

Thanks, David