From: David Edelsohn <dje.gcc@gmail.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR59844, Fix gcc 4.9 power8 -O3 little endian direct move paterns
Date: Thu, 16 Jan 2014 16:51:00 -0000 [thread overview]
Message-ID: <CAGWvny=_vUwiG8PM+SO_SdxdQHwsic0N3bbr82y-q01Lz3028Q@mail.gmail.com> (raw)
In-Reply-To: <20140116160801.GA8407@ibm-tiger.the-meissners.org>
On Thu, Jan 16, 2014 at 11:08 AM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> This patch fixes the problem that was noticed when we attempted to boostrap the
> compiler on a little endian power8 system with the -O3 -mcpu=power8 options.
>
> During the development of the power8 direct move patches, I put a guard test in
> the 128-bit direct move insns to make the patterns big endian only. Since I
> used gen_highpart and gen_lowpart to generate the SUBREGs in the split, the
> existing code is safe for little endian. This patch removes the big endian
> guard tests.
>
> This patch has been regression tested on a little endian power8 system, and it
> allows the code to compile. I looked at the assembler generated, and it looks
> correct. Is this patch ok to apply?
>
> 2014-01-16 Michael Meissner <meissner@linux.vnet.ibm.com>
>
> * config/rs6000/rs6000.md (reload_vsx_from_gprsf): Add little
> endian support, remove tests for WORDS_BIG_ENDIAN.
> (p8_mfvsrd_3_<mode>): Likewise.
> (reload_gpr_from_vsx<mode>): Likewise.
> (reload_gpr_from_vsxsf): Likewise.
> (p8_mfvsrd_4_disf): Likewise.
Okay. Thanks Mike and Bill for tracking this down and testing.
Thanks, David
prev parent reply other threads:[~2014-01-16 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:08 Michael Meissner
2014-01-16 16:51 ` David Edelsohn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=_vUwiG8PM+SO_SdxdQHwsic0N3bbr82y-q01Lz3028Q@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).