public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: "REIX, Tony" <tony.reix@atos.net>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
		"SARTER, MATTHIEU (ext)" <matthieu.sarter.external@atos.net>
Subject: Re: [PATCH,AIX] Enable Stack Unwinding on AIX
Date: Tue, 16 May 2017 14:27:00 -0000	[thread overview]
Message-ID: <CAGWvny=k=bgtvUCNuuUMj36+P2S1dtOK5Vu+NzeBFFPrUp03mg@mail.gmail.com> (raw)
In-Reply-To: <B37989F2852398498001550C29155BE5CD3A5D@FRCRPVV9EX3MSX.ww931.my-it-solutions.net>

On Tue, May 16, 2017 at 9:50 AM, REIX, Tony <tony.reix@atos.net> wrote:
> Tests:
>
> The change has been tested in 32bit and 64bit on AIX 6.1, 7.1 & 7.2 by using the libbacktrace (with XCOFF support) within a signal handler context (we used a specific back.c program).
> And it has been tested with Go tests on AIX for sure (recover tests on SIGSEGV do not work without this change).
>
> ChangeLog:
>
> * config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64 bit support for AIX 6.1 and 7.X and 32 bit support for AIX 7.2.

If ppc_aix_fallback_frame_state is used for both 32 bit and 64 bit,
there is no need to define it twice.  Just move the
MD_FALLBACK_FRAME_STATE_FOR macro definition outside the #ifdef.  This
also needs a separate ChangeLog comment.

The function that you modified is "ucontext_for".  Please use that
name in the ChangeLog entry.

Will you need someone to apply the patch for you?

Thanks, David

  reply	other threads:[~2017-05-16 14:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 20:31 David Edelsohn
2017-05-16 13:53 ` REIX, Tony
2017-05-16 14:27   ` David Edelsohn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-05-15 15:49 [PATCH,AIX] " REIX, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWvny=k=bgtvUCNuuUMj36+P2S1dtOK5Vu+NzeBFFPrUp03mg@mail.gmail.com' \
    --to=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=matthieu.sarter.external@atos.net \
    --cc=tony.reix@atos.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).