From: David Edelsohn <dje.gcc@gmail.com>
To: Bill Schmidt <wschmidt@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH, committed] rs6000: Don't let swaps pass break multiply low-part (PR101129)
Date: Thu, 15 Jul 2021 11:29:11 -0400 [thread overview]
Message-ID: <CAGWvny=nJD9DnoDPJObJ1pQEJbww1OjZtK2JV6Bshvb=m_dziA@mail.gmail.com> (raw)
In-Reply-To: <b4b7c76b-1374-d417-e503-425c4538630f@linux.ibm.com>
On Thu, Jul 15, 2021 at 11:25 AM Bill Schmidt <wschmidt@linux.ibm.com> wrote:
>
> Hi,
>
> Segher preapproved this patch in https://gcc.gnu.org/PR101129. It differs slightly from what was posted there, needing an additional test to ensure the insn is a SET. The patch also includes the test case provided by the OP. Bootstrap and regtest succeeded on P9 little-endian.
>
> This bug has been around a long time, so the fix should be backported to all open releases. Is this okay after some burn-in time?
>
> Thanks!
> Bill
>
> rs6000: Don't let swaps pass break multiply low-part (PR101129)
>
> 2021-07-15 Bill Schmidt <wschmidt@linux.ibm.com>
>
> gcc/
> * config/rs6000/rs6000-p8swap.c (has_part_mult): New.
> (rs6000_analyze_swaps): Insns containing a subreg of a mult are
> not swappable.
>
> gcc/testsuite/
> * gcc.target/powerpc/pr101129.c: New.
Thanks for fixing this so quickly.
Okay everywhere.
Thanks, David
prev parent reply other threads:[~2021-07-15 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 15:25 Bill Schmidt
2021-07-15 15:29 ` David Edelsohn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=nJD9DnoDPJObJ1pQEJbww1OjZtK2JV6Bshvb=m_dziA@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).