From: David Edelsohn <dje.gcc@gmail.com>
To: "REIX, TONY" <tony.reix@atos.net>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"SARTER, MATTHIEU (ext)" <matthieu.sarter.external@atos.net>
Subject: Re: [PATCH,AIX] Enable Stack Unwinding on AIX
Date: Mon, 15 May 2017 20:31:00 -0000 [thread overview]
Message-ID: <CAGWvny=oM8gJcivfq7K32oDzx+accYE=SPVhKUiogvWFSJZFww@mail.gmail.com> (raw)
Please do not email my IBM Notes address with patches. Please copy
this Gmail address for patch submissions.
> * libgcc/config/rs6000/aix-unwind.h : Implements stack unwinding on AIX.
This ChangeLog entry clearly is wrong because aix-unwind.h already
implements ppc_aix_fallback_frame_state. The ChangeLog entry should
reference the exact function being modified and a useful comment about
how it is modified, e.g.,
* config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64
bit support Add 32 bit support for AIX 6.1 and 7.2.
The ChangeLog file is in libgcc, so the file reference is wrong
because it should not use libgcc in the path.
How was this tested?
Thanks, David
next reply other threads:[~2017-05-15 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 20:31 David Edelsohn [this message]
2017-05-16 13:53 ` REIX, Tony
2017-05-16 14:27 ` [PATCH,AIX] " David Edelsohn
-- strict thread matches above, loose matches on Subject: below --
2017-05-15 15:49 REIX, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=oM8gJcivfq7K32oDzx+accYE=SPVhKUiogvWFSJZFww@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matthieu.sarter.external@atos.net \
--cc=tony.reix@atos.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).