From: David Edelsohn <dje.gcc@gmail.com>
To: Xinliang David Li <davidxl@google.com>, Jan Hubicka <hubicka@ucw.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: FDO patch -- make ic related vars TLS if target allows
Date: Fri, 28 Dec 2012 16:26:00 -0000 [thread overview]
Message-ID: <CAGWvny=vmTV9TkYF1=ZEk5F=NuiwsHovosdFcsFs8iSF2FYZEA@mail.gmail.com> (raw)
David,
Support for native TLS on AIX exposed a problem with this patch. A
similar problem exists on Solaris 9.
Some helper functions for TLS on AIX and Solaris 9 only are provided
by libpthread. Promoting ic related variables to TLS breaks profiling
of non-pthread appications. I completely agree with reducing race
conditions and improving support for profiling of pthread
applications, but why should this change be enabled for applications
not built and run as multi-threaded? This feature should test more
than the existence of target TLS support.
Thanks, David
next reply other threads:[~2012-12-28 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 16:26 David Edelsohn [this message]
2012-12-28 19:09 ` Xinliang David Li
2012-12-28 19:47 ` David Edelsohn
-- strict thread matches above, loose matches on Subject: below --
2011-04-27 18:17 Xinliang David Li
2011-04-28 13:06 ` Jan Hubicka
2011-05-17 16:08 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvny=vmTV9TkYF1=ZEk5F=NuiwsHovosdFcsFs8iSF2FYZEA@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).