From: David Edelsohn <dje.gcc@gmail.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Another AIX Bootstrap failure
Date: Mon, 16 Jun 2014 18:55:00 -0000 [thread overview]
Message-ID: <CAGWvnyk+fot-uRkE1LhW33p9HHR5CWPBY5OrK+GvJghmtYOu+w@mail.gmail.com> (raw)
In-Reply-To: <20140616043557.GA6530@kam.mff.cuni.cz>
On Mon, Jun 16, 2014 at 12:35 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
> @@ -512,9 +516,9 @@ function_and_variable_visibility (bool w
> next = next->same_comdat_group)
> {
> next->set_comdat_group (NULL);
> - if (!next->alias)
> - next->set_section (NULL);
> symtab_make_decl_local (next->decl);
> + if (!node->alias)
> + node->reset_section ();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> next->unique_name = ((next->resolution == LDPR_PREVAILING_DEF_IRONLY
> || next->unique_name
> || next->resolution == LDPR_PREVAILING_DEF_IRONLY_EXP)
Honza, did you really intend to change the above from next->alias and
next->set_section () to node->alias and node->reset_section () ? That
doesn't look right.
- David
next prev parent reply other threads:[~2014-06-16 18:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 3:31 David Edelsohn
2014-06-16 4:36 ` Jan Hubicka
2014-06-16 11:53 ` David Edelsohn
2014-06-16 15:08 ` Jan Hubicka
2014-06-16 16:16 ` Ramana Radhakrishnan
2014-06-16 17:13 ` David Edelsohn
2014-06-16 21:44 ` Jan Hubicka
2014-06-16 22:42 ` David Edelsohn
2014-06-16 12:01 ` Ramana Radhakrishnan
2014-06-16 18:55 ` David Edelsohn [this message]
2014-06-16 22:06 ` Jan Hubicka
2014-06-17 1:51 ` David Edelsohn
2014-06-17 2:55 ` David Edelsohn
2014-06-17 3:44 ` Jan Hubicka
2014-06-17 14:07 ` David Edelsohn
2014-06-17 16:51 ` Jan Hubicka
2014-06-17 16:57 ` David Edelsohn
2014-06-21 2:43 ` Jan Hubicka
2014-06-21 22:47 ` David Edelsohn
2014-06-21 23:04 ` Jan Hubicka
2014-06-22 14:47 ` David Edelsohn
2014-06-22 19:12 ` Jan Hubicka
2014-06-23 16:49 Dominique Dhumieres
2014-06-23 17:36 ` Jan Hubicka
2014-06-24 19:36 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnyk+fot-uRkE1LhW33p9HHR5CWPBY5OrK+GvJghmtYOu+w@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).