From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) by sourceware.org (Postfix) with ESMTPS id 87ADF3857C70 for ; Mon, 13 Dec 2021 16:30:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87ADF3857C70 Received: by mail-ua1-x935.google.com with SMTP id p2so30101949uad.11 for ; Mon, 13 Dec 2021 08:30:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n/W0MN7GFE3sffDGLjOj493du52gyeTtWMm8jlP4WtI=; b=t/FQF7zf+PkKT6kHiqR5KTHkjIDb4BueiKuo2ihOs0+WACnwFTgx8+MAT5cRrgHz+t cYizlfVeEv1vbBe6gzgf/wyipBaAygNOEL85WDYl/YDYXtleZ1DeYlwFOFmTS16ucUqU y9MQ8B4OxrIRg9zDhH4gi2ypC4PieNpUG+ghKX3BFgewXXJk6KMVQeXtLa1XNIaugWWY 00Q66U8MypIhTjldJX6q19jlBONRKPKt6AKTvi1DVBl+h8h7PgIwcb2HRN1c3mWPcKgs W33+6zkfLJWn4ThlIIz2cJvIJagFIZw3DUBDegEcVO/N3/vIuhdbH/iI/eVHkdl9mAxU VPXw== X-Gm-Message-State: AOAM533UR9mxg1ezhTCKjwQE98twSxJhIpw7OmARzhLGZm73yI03HRFj zfgouhPHf3SUEvAprAGilHITIwkeLNceXLNKJeRY+nZl X-Google-Smtp-Source: ABdhPJwz5AXcUgiOcBVjBjs3OyA33TrydG7VVKafwdT93vOhhMdzii0lc53m1kN5MWBMOyRXI0ozgI9zXttGVMwkWfc= X-Received: by 2002:a67:cb0d:: with SMTP id b13mr10697598vsl.81.1639413039118; Mon, 13 Dec 2021 08:30:39 -0800 (PST) MIME-Version: 1.0 References: <21f6c411-8aed-6042-2e76-5649ac95d259@linux.ibm.com> In-Reply-To: <21f6c411-8aed-6042-2e76-5649ac95d259@linux.ibm.com> From: David Edelsohn Date: Mon, 13 Dec 2021 11:30:28 -0500 Message-ID: Subject: Re: [PATCH] rs6000: __builtin_darn[_raw] should be in [power9-64] (PR103624) To: Bill Schmidt Cc: GCC Patches , Segher Boessenkool Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 16:30:41 -0000 On Mon, Dec 13, 2021 at 10:48 AM Bill Schmidt wrote: > > Hi! > > PR103624 observes that we get segfaults for the 64-bit darn builtins when compiled > on a 32-bit architecture. The old built-in infrastructure requires TARGET_64BIT, and > this was missed in the new support. Moving these two builtins from the [power9] > stanza to the [power9-64] stanza solves the problem. > > Tested the fix on a powerpc-e300c3-linux-gnu cross. Bootstrapped and tested on > powerpc64le-linux-gnu with no regressions. Is this okay for trunk? Okay. Thanks, David > > Thanks! > Bill > > > 2021-12-13 Bill Schmidt > > gcc/ > PR target/103624 > * config/rs6000/rs6000-builtin-new.def (__builtin_darn): Move to > [power9-64] stanza. > (__builtin_darn_raw): Likewise. > --- > gcc/config/rs6000/rs6000-builtin-new.def | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtin-new.def b/gcc/config/rs6000/rs6000-builtin-new.def > index 30556e5c7f2..2becd96a36c 100644 > --- a/gcc/config/rs6000/rs6000-builtin-new.def > +++ b/gcc/config/rs6000/rs6000-builtin-new.def > @@ -2799,15 +2799,9 @@ > > ; Miscellaneous P9 functions > [power9] > - signed long long __builtin_darn (); > - DARN darn {} > - > signed int __builtin_darn_32 (); > DARN_32 darn_32 {} > > - signed long long __builtin_darn_raw (); > - DARN_RAW darn_raw {} > - > const signed int __builtin_dtstsfi_eq_dd (const int<6>, _Decimal64); > TSTSFI_EQ_DD dfptstsfi_eq_dd {} > > @@ -2840,6 +2834,12 @@ > void __builtin_altivec_stxvl (vsc, void *, long); > STXVL stxvl {} > > + signed long long __builtin_darn (); > + DARN darn {} > + > + signed long long __builtin_darn_raw (); > + DARN_RAW darn_raw {} > + > const signed int __builtin_scalar_byte_in_set (signed int, signed long long); > CMPEQB cmpeqb {} > > -- > 2.27.0 > >