From: David Edelsohn <dje.gcc@gmail.com>
To: Bill Schmidt <wschmidt@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH] rs6000: Fix vec_cpsgn parameter order (PR101985)
Date: Tue, 12 Oct 2021 14:59:26 -0400 [thread overview]
Message-ID: <CAGWvnykG8XWxqt2dMjY95mKx-p0cAhX7oh_m1Mvx1mXdzR2oLg@mail.gmail.com> (raw)
In-Reply-To: <0f9bde3b-e6f3-1d4f-cf76-6ac345bfe07d@linux.ibm.com>
On Fri, Sep 24, 2021 at 11:20 AM Bill Schmidt <wschmidt@linux.ibm.com> wrote:
>
> Hi!
>
> This fixes a bug reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101985.
>
> The vec_cpsgn built-in function API differs in argument order from the
> copysign<mode>3 convention. Currently that pattern is incorrectly used to
> implement vec_cpsgn. Fix that while leaving the existing pattern in place
> to implement copysignf for vector modes.
It's a little confusing what "that" is. Maybe clarify that the patch
is changing the PowerPC VSX function to invoke the GCC built-in with
the argument in the correct order.
>
> Part of the fix when using the new built-in support requires an adjustment
> to a pending patch that replaces much of altivec.h with an automatically
> generated file. So that adjustment will be coming later...
>
> Also fix a bug in the new built-in overload infrastructure where we were
> using the VSX form of the VEC_COPYSIGN built-in when we should default to
> the VMX form.
>
> Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no regressions.
> Is this okay for trunk?
>
> Thanks!
> Bill
>
>
> 2021-09-24 Bill Schmidt <wschmidt@linux.ibm.com>
>
> gcc/
> PR target/101985
> * config/rs6000/altivec.h (vec_cpsgn): Adjust.
Maybe a little more information than "Adjust"? Swap arguments?
> * config/rs6000/rs6000-overload.def (VEC_COPYSIGN): Use SKIP to
> avoid generating an automatic #define of vec_cpsgn. Use the
> correct built-in for V4SFmode that doesn't depend on VSX.
>
> gcc/testsuite/
> PR target/101985
> * gcc.target/powerpc/pr101985.c: New.
Okay.
Thanks, David
next prev parent reply other threads:[~2021-10-12 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 15:20 Bill Schmidt
2021-10-11 22:15 ` Bill Schmidt
2021-10-12 18:59 ` David Edelsohn [this message]
2021-10-12 21:37 ` Segher Boessenkool
2021-10-12 22:41 ` Bill Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnykG8XWxqt2dMjY95mKx-p0cAhX7oh_m1Mvx1mXdzR2oLg@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).