* [PATCH, testsuite] Fix ifcvt-4.c for PowerPC
@ 2016-03-14 20:23 Pat Haugen
2016-03-14 23:35 ` Jeff Law
2016-03-15 14:12 ` David Edelsohn
0 siblings, 2 replies; 4+ messages in thread
From: Pat Haugen @ 2016-03-14 20:23 UTC (permalink / raw)
To: GCC Patches, David Edelsohn
As stated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68232, this
test needs -misel on powerpc to pass. Verified the following fixes the
test on both powerpc64/powerpc64le. Ok for trunk?
-Pat
testsuite/ChangeLog:
2016-03-14 Pat Haugen <pthaugen@us.ibm.com>
* gcc.dg/ifcvt-4.c: Add -misel for powerpc* and remove skip for
powerpc64le.
Index: testsuite/gcc.dg/ifcvt-4.c
===================================================================
--- testsuite/gcc.dg/ifcvt-4.c (revision 234189)
+++ testsuite/gcc.dg/ifcvt-4.c (working copy)
@@ -1,5 +1,6 @@
/* { dg-options "-fdump-rtl-ce1 -O2 --param
max-rtl-if-conversion-insns=3" } */
-/* { dg-skip-if "Multiple set if-conversion not guaranteed on all
subtargets" { "arm*-*-* powerpc64le*-*-* visium-*-*" } {"*"} { "" } } */
+/* { dg-additional-options "-misel" { target { powerpc*-*-* } } } */
+/* { dg-skip-if "Multiple set if-conversion not guaranteed on all
subtargets" { "arm*-*-* visium-*-*" } {"*"} { "" } } */
int
foo (int x, int y, int a)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, testsuite] Fix ifcvt-4.c for PowerPC
2016-03-14 20:23 [PATCH, testsuite] Fix ifcvt-4.c for PowerPC Pat Haugen
@ 2016-03-14 23:35 ` Jeff Law
2016-03-14 23:40 ` David Edelsohn
2016-03-15 14:12 ` David Edelsohn
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Law @ 2016-03-14 23:35 UTC (permalink / raw)
To: Pat Haugen, GCC Patches, David Edelsohn
On 03/14/2016 02:23 PM, Pat Haugen wrote:
> As stated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68232, this
> test needs -misel on powerpc to pass. Verified the following fixes the
> test on both powerpc64/powerpc64le. Ok for trunk?
>
> -Pat
>
> testsuite/ChangeLog:
> 2016-03-14 Pat Haugen <pthaugen@us.ibm.com>
>
> * gcc.dg/ifcvt-4.c: Add -misel for powerpc* and remove skip for
> powerpc64le.
OK.
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, testsuite] Fix ifcvt-4.c for PowerPC
2016-03-14 23:35 ` Jeff Law
@ 2016-03-14 23:40 ` David Edelsohn
0 siblings, 0 replies; 4+ messages in thread
From: David Edelsohn @ 2016-03-14 23:40 UTC (permalink / raw)
To: Jeff Law; +Cc: Pat Haugen, GCC Patches
On Mon, Mar 14, 2016 at 7:35 PM, Jeff Law <law@redhat.com> wrote:
> On 03/14/2016 02:23 PM, Pat Haugen wrote:
>>
>> As stated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68232, this
>> test needs -misel on powerpc to pass. Verified the following fixes the
>> test on both powerpc64/powerpc64le. Ok for trunk?
>>
>> -Pat
>>
>> testsuite/ChangeLog:
>> 2016-03-14 Pat Haugen <pthaugen@us.ibm.com>
>>
>> * gcc.dg/ifcvt-4.c: Add -misel for powerpc* and remove skip for
>> powerpc64le.
>
> OK.
> jeff
The change is going to fail on PowerPC systems that don't support
ISEL, so it needs to be adjusted.
- David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, testsuite] Fix ifcvt-4.c for PowerPC
2016-03-14 20:23 [PATCH, testsuite] Fix ifcvt-4.c for PowerPC Pat Haugen
2016-03-14 23:35 ` Jeff Law
@ 2016-03-15 14:12 ` David Edelsohn
1 sibling, 0 replies; 4+ messages in thread
From: David Edelsohn @ 2016-03-15 14:12 UTC (permalink / raw)
To: Pat Haugen; +Cc: GCC Patches
On Mon, Mar 14, 2016 at 4:23 PM, Pat Haugen <pthaugen@linux.vnet.ibm.com> wrote:
> As stated in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68232, this test
> needs -misel on powerpc to pass. Verified the following fixes the test on
> both powerpc64/powerpc64le. Ok for trunk?
>
> -Pat
>
> testsuite/ChangeLog:
> 2016-03-14 Pat Haugen <pthaugen@us.ibm.com>
>
> * gcc.dg/ifcvt-4.c: Add -misel for powerpc* and remove skip for
> powerpc64le.
The -misel flag will override the code generation, even if the
architecture setting doesn't support the instruction. I guess this is
good enough for the compile-only test.
This is okay.
Thanks, David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-15 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-14 20:23 [PATCH, testsuite] Fix ifcvt-4.c for PowerPC Pat Haugen
2016-03-14 23:35 ` Jeff Law
2016-03-14 23:40 ` David Edelsohn
2016-03-15 14:12 ` David Edelsohn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).