From: David Edelsohn <dje.gcc@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
Iain Sandoe <iain@sandoe.co.uk>,
"libstdc++" <libstdc++@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>,
"CHIGOT, CLEMENT" <clement.chigot@atos.net>
Subject: Re: [PATCH, libstdc++] GLIBCXX_HAVE_INT64_T
Date: Wed, 6 Jan 2021 19:41:38 -0500 [thread overview]
Message-ID: <CAGWvnykMChDFMuu2fm9GnyKTYvb70Pvhz4_5bSmbVWmjZbHW0A@mail.gmail.com> (raw)
In-Reply-To: <20210106234549.GA3748@tucnak>
Thanks for clarifying the issue.
As you implicitly point out, GCC knows the type of INT64 and defines
the macro __INT64_TYPE__ . The revised code can use that directly,
such as:
#if defined(_GLIBCXX_HAVE_INT64_T_LONG) \
|| defined(_GLIBCXX_HAVE_INT64_T_LONG_LONG)
typedef __INT64_TYPE__ streamoff;
#elif defined(_GLIBCXX_HAVE_INT64_T)
typedef int64_t streamoff;
#else
typedef long long streamoff;
#endif
Are there any additional issues not addressed by that approach, other
than possible further simplification?
Thanks, David
On Wed, Jan 6, 2021 at 6:45 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Thu, Jan 07, 2021 at 12:39:39AM +0100, Jakub Jelinek wrote:
> > We are talking past each other.
> >
> > Consider an OS that has in stdint.h
> > typedef long long int64_t;
>
> And, from grepping INT64_TYPE in config/* config/*/*
> it isn't just theoretic, Darwin and OpenBSD behave that way.
>
> Jakub
>
next prev parent reply other threads:[~2021-01-07 0:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 18:38 David Edelsohn
2021-01-06 18:55 ` Marc Glisse
2021-01-06 19:11 ` David Edelsohn
2021-01-06 19:37 ` Jakub Jelinek
2021-01-06 21:20 ` David Edelsohn
2021-01-06 21:41 ` Jakub Jelinek
2021-01-06 23:01 ` David Edelsohn
2021-01-06 23:39 ` Jakub Jelinek
2021-01-06 23:45 ` Jakub Jelinek
2021-01-07 0:41 ` David Edelsohn [this message]
2021-01-08 18:37 ` Jonathan Wakely
2021-01-08 18:52 ` Jakub Jelinek
2021-01-08 20:35 ` David Edelsohn
2021-04-29 20:06 ` David Edelsohn
2021-04-29 20:23 ` Jonathan Wakely
2021-04-30 19:31 ` Jonathan Wakely
2021-04-30 20:18 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnykMChDFMuu2fm9GnyKTYvb70Pvhz4_5bSmbVWmjZbHW0A@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=clement.chigot@atos.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).