From: David Edelsohn <dje.gcc@gmail.com>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: Thomas Koenig <tkoenig@netcologne.de>,
Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR fortran/83522 – reject array-valued substrings
Date: Thu, 11 Oct 2018 14:20:00 -0000 [thread overview]
Message-ID: <CAGWvnykOLsiw-XNrDuQeoGLaB648f-MCD-7J=zRL4JL1=XLfJQ@mail.gmail.com> (raw)
In-Reply-To: <CAGkQGiKPgo81h6=-oGjak1j3Y99FMwc6UbXw4g6_Wf1-soRtMQ@mail.gmail.com>
Apparently this change also breaks CPU SPEC (465.tonto?).
Is this really a correct change? Even if the testcases really are
wrong, it seems that this change is going to break a lot of code in
the wild. This seems like a very bad choice, even if it pedantically
is correct.
Thanks, David
On Wed, Oct 10, 2018 at 7:12 PM Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
>
> This seems to have caused errors in the testsuite. I guess that the
> problem is that the testcases are invalid :-(
>
> From David Edelsohn:
> Error: Substring reference of nonscalar not permitted at (1)
>
> arrayio_11.f90
> arrayio_12.f90
> associate_23.f90
> data_char_1.f90
> deferred_character_2.f90
> deferred_character_22.f90
> deferred_character_23.f90
> deferred_character_8.f90
> deferred_type_component_3.f90
>
> Cheers
>
> Paul
>
> On Mon, 8 Oct 2018 at 23:16, Thomas Koenig <tkoenig@netcologne.de> wrote:
> >
> > Hi Tobias,
> >
> > nice to hear from you again!
> >
> > > Build and regtested on x86_64-linux.
> > > OK for the trunk?
> >
> > OK. Thanks for the patch!
> >
> > Regards
> >
> > Thomas
>
>
>
> --
> "If you can't explain it simply, you don't understand it well enough"
> - Albert Einstein
next prev parent reply other threads:[~2018-10-11 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c0ed507e-bf17-ea71-6715-906c10ee054d@net-b.de>
2018-10-08 22:24 ` Thomas Koenig
2018-10-11 0:14 ` Paul Richard Thomas
2018-10-11 14:20 ` David Edelsohn [this message]
2018-10-11 14:31 ` David Edelsohn
2018-10-11 15:20 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnykOLsiw-XNrDuQeoGLaB648f-MCD-7J=zRL4JL1=XLfJQ@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).