Re: OpenACC 'kernels' testsuite failures

[David Edelsohn <dje.gcc@gmail.com>]

On Mon, Nov 16, 2020 at 9:16 AM Thomas Schwinge <thomas@codesourcery.com> wrote:
>
> Hi David!
>
> Thanks for reporting.
>
> On 2020-11-15T15:47:15-0500, David Edelsohn <dje.gcc@gmail.com> wrote:
> > I am seeing a number of new failures on AIX related to the OpenACC
> > kernels patches.
> >
> > c-c++-common/goacc/kernels-decompose-1.c
> > c-c++-common/goacc/kernels-decompose-2.c
> > gfortran.dg/goacc/kernels-decompose-1.f95
> > gfortran.dg/goacc/kernels-decompose-2.f95
> > libgomp.oacc-c++/../libgomp.oacc-c-c++-common/kernels-decompose-1.c
> > libgomp.oacc-fortran/pr94358-1.f90
>
> I suppose what you're asking about is what appears in
> <gcc-testresults@gcc.gnu.org> reports as:
>
>     ERROR: c-c++-common/goacc/kernels-decompose-1.c: can't read "c_loop_i": no such variable for " dg-line 24 l_loop_i[incr c_loop_i] "
>     UNRESOLVED: c-c++-common/goacc/kernels-decompose-1.c: can't read "c_loop_i": no such variable for " dg-line 24 l_loop_i[incr c_loop_i] "
>
> Etc.
>
> However, per the reports posted there, these really only (!) appear to
> fail for your "Native configuration is powerpc-ibm-aix7.2.3.0" testing,
> strange.  Which versions of DejaGnu and Tcl are used?

For my internal tester DejaGNU reports the following:

Expect version is 5.42.1
Tcl version is 8.4
Framework version is 1.5.3

>
> On <https://cfarm.tetaneutral.net/machines/list/> I see there are AIX
> systems gcc111, gcc119 -- maybe I'll have luck reproducing the issue
> there.
>
> Admittedly, using Tcl code inside DejaGnu directives is not most common,
> but it does make sense conceptually (at least to me), and reportedly does
> work with a large number of DejaGnu/Tcl versions combinations.
>
> > Looking at the testsuite logs I see:
> >
> > fatal error: GCC is not configured to support amdgcn-amdhsa as offload target
>
> That one's not actually related to the new OpenACC 'kernels' testcases:
> it's just the testsuite harness checking whether GCN offloading is
> configured.  (See <https://gcc.gnu.org/PR88920> "GCC is not configured to
> support amdgcn-unknown-amdhsa as offload target"; this should one appear
> once per testsuite.)
>
> > I don't know why this is different from the other OpenACC tests.
>
> It's not.  At least not intentionally.

I don't see any obvious difference in the style of the additional
options for the kernels testcases versus others, although it
specifically is using an option for that test.  I only see the "GCC is
not configured ... amdhsa" for those tests.

>
> > How
> > should these tests be skipped or adjusted to not fail on other
> > systems?
>
> They are expected to work fine on all systems; they're not specific to
> actual code offloading.  So if something FAILs, we shall resolve it.

Thanks, David