From: David Edelsohn <dje.gcc@gmail.com>
To: Peter Bergner <bergner@vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
"William J. Schmidt" <wschmidt@linux.vnet.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins
Date: Tue, 06 Feb 2018 01:32:00 -0000 [thread overview]
Message-ID: <CAGWvnykUfYDOHzTEB_PSqHqaj-MyhOazPpHbqFRhVOtaJV6xbg@mail.gmail.com> (raw)
Peter,
Why can't you place the tests into the final condition of the pattern
so that the pattern fails and the normal GCC fallback machinery is
used instead of manually implementing the fallback emulation?
The GPR iterator only defines DI for TARGET_POWERPC64, so how does GCC
get into the muldi3 pattern, for example, and also satisfy both
(define_mode_iterator GPR [SI (DI "TARGET_POWERPC64")])
<MODE>mode == DImode && !TARGET_POWERPC64
This seems contradictory.
Thanks, David
next reply other threads:[~2018-02-06 1:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 1:32 David Edelsohn [this message]
2018-02-06 2:43 ` Peter Bergner
2018-02-06 4:48 ` David Edelsohn
2018-02-06 12:42 ` Peter Bergner
2018-02-06 13:21 ` Segher Boessenkool
2018-02-06 15:43 ` Peter Bergner
2018-02-06 16:20 ` David Edelsohn
2018-02-06 16:36 ` Peter Bergner
2018-02-06 17:40 ` Segher Boessenkool
2018-02-06 19:55 ` Peter Bergner
2018-02-08 16:38 ` Peter Bergner
2018-02-08 18:28 ` Peter Bergner
2018-02-09 16:51 ` Segher Boessenkool
2018-02-09 17:09 ` Peter Bergner
2018-02-09 16:17 ` Segher Boessenkool
2018-02-09 16:39 ` Peter Bergner
-- strict thread matches above, loose matches on Subject: below --
2018-02-06 0:07 Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnykUfYDOHzTEB_PSqHqaj-MyhOazPpHbqFRhVOtaJV6xbg@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=bergner@vnet.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).