From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id 5B7E93858D37 for ; Fri, 4 Feb 2022 00:18:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B7E93858D37 Received: by mail-ua1-x934.google.com with SMTP id w18so4895319uar.8 for ; Thu, 03 Feb 2022 16:18:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JGuspAKoOi7hdQwh0Ip5LdJeXq7vwim9XFCZQXQd9tk=; b=Nv/BVekv0D2xhmq2k6vz7DpOXUTbW9hODZI7w47XxFBKfKDbEwt4vFCqhFjk+cj4SP TOffsAb6nQijf9c4YK4ynYvcUQsLNGZcjjYGoB0J8sCDEa09TKF0xHY3pIvlJV0Iior3 wPW9QP0RjVrHwWY1pADlVphuux30Z4xkWfLkQtuSs3kx9Dv8uUqiDhDEv9KfXqYqAUFr YaoWBq2bPXvPcbJxssC9RlcYlnVF6yoQmz2Y9E3bNFKbwprgb/XFPQLkeL1XG6GuE7GC 04GgvniL0V8k3FC7Z35r0wWbONT3+ra2lIfO35SJUTntuHRzkeXCs8Rv3GUZjUJHwRRU lPOQ== X-Gm-Message-State: AOAM5322B2yTApHl75uOJwI9h23OV9LieKN//5g8GSKjhDQyc3NCp46K KPAqQY7IhucSIBzm8aRK9RIqK0vYsa5SeoHUU6ax2dTs X-Google-Smtp-Source: ABdhPJxg53b6HLb4DPqYHcI1B2K2KRZ0Z1JLSiM+N39aUCIf7r/eLPWSO4QuHXYWN0MO+MXQq9ulplB4bH3Xy37BSlU= X-Received: by 2002:ab0:1ecb:: with SMTP id p11mr168907uak.113.1643933891896; Thu, 03 Feb 2022 16:18:11 -0800 (PST) MIME-Version: 1.0 References: <008f4f40-3d6c-6e50-5b95-c20444a50873@gmail.com> In-Reply-To: <008f4f40-3d6c-6e50-5b95-c20444a50873@gmail.com> From: David Edelsohn Date: Thu, 3 Feb 2022 19:18:01 -0500 Message-ID: Subject: Re: [PATCH 0/3] Enable pointer_query caching throughout. To: Martin Sebor Cc: GCC Patches , Richard Biener Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 00:18:13 -0000 On Thu, Feb 3, 2022 at 6:09 PM Martin Sebor wrote: > > On 2/3/22 15:56, David Edelsohn wrote: > > This series of patches has exploded memory usage and I can no longer > > bootstrap GCC on AIX. > > > > As with the Ranger problem exposed by Aldy's patch last September, > > something is not freeing memory. > > > > Even on systems where GCC still bootstrap, this excessive memory usage > > severely damages GCC compile performance. > > Does the change below by any chance make a difference? (It's just > a hunch, I haven't tested it beyond quickly building stage 1 and > running a few tests.) Hi, Martin Thanks for the quick response. Yes, I am able to restore bootstrap on AIX (32 bit) with the change. Thanks, David > > Martin > > > diff --git a/gcc/pointer-query.h b/gcc/pointer-query.h > index 4c725eeaf34..801a240c38d 100644 > --- a/gcc/pointer-query.h > +++ b/gcc/pointer-query.h > @@ -164,9 +164,9 @@ class pointer_query > struct cache_type > { > /* 1-based indices into cache. */ > - vec indices; > + auto_vec indices; > /* The cache itself. */ > - vec access_refs; > + auto_vec access_refs; > }; > > public: