From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 246613858D35 for ; Thu, 30 Jul 2020 08:36:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 246613858D35 Received: by mail-wm1-x341.google.com with SMTP id g10so3813109wmc.1 for ; Thu, 30 Jul 2020 01:36:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zrnj2W2vDRhi+ywMoE+IeXLGs4qyBinYqH2x2PQX8Lk=; b=B+aYBnnjZic4YXXAviJZwfXRckdaopTq00WqQsEJ8YcIFWItJE91nKkyweQXkZBxp4 vo4F5H+kzYLlqOZ+tugFRxJGaHQBKw08LSgdvUXf7PY40o6YNZ9DlkffRXRZ2bo4FfTK ETZsbED2Dn6zwmbgfyQDt3uyMDa15Qg3lMCWD0KpecNuisk76VjzRNAsS8cPWgP1Vjh2 hBbeSziKSyVNHFxiavVr0k2IICf7Eq8/oqmfoBbaSGHJ5AqGOHkcb8BSQw3fZpFurZtI LqNzLaiHc3wrColl24HXScyRz9Est6Ebpyb7GP6fmTJrrsElhZiImzBLwmIHu15o2aP1 vwiQ== X-Gm-Message-State: AOAM532sKI0dFV+CCWA6fGRB7kvy0VALziJVnLkhnH4icvk9Ww7W0uTh KdWKUfoLvfny2g2dKSrxqB1EDubZK2mEFH1QJuM= X-Google-Smtp-Source: ABdhPJx+geRSQec9ZcaV6CF/ifKoJGpB4QCfjpgAGuITnPknT95SnXstZWUXdZ1jRA9jRMqoNMkjFSYJqCGVHKRQ0Xw= X-Received: by 2002:a1c:7f91:: with SMTP id a139mr11925847wmd.153.1596098170111; Thu, 30 Jul 2020 01:36:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Edelsohn Date: Thu, 30 Jul 2020 04:35:57 -0400 Message-ID: Subject: Re: [PATCH, rs6000] Add non-relative jump table support for 64bit rs6000 To: HAO CHEN GUI Cc: GCC Patches , Segher Boessenkool , Bill Schmidt Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 08:36:12 -0000 On Thu, Jul 30, 2020 at 1:22 AM HAO CHEN GUI wrote: > > David, > > Seems there is something wrong with my email box. I lost your email. I > reconfigured the box and it should be OK now. > > Could you inform me how to exclude AIX from the condition testing? By > the ABI? Thanks a lot. The purpose should not be to exclude AIX. If there is no fundamental limitation with use of the new tablejump design on AIX then the patch is not acceptable without AIX support. The patch should use DOUBLE_INT_ASM_OP, not explicit ".quad". AIX always is PIC. It's not obvious to me why the patch should limit support to PPC64 Linux. The section selection seems Linux/ELF specific, but the rest seems like a general design optimization for all PowerPC-based operating systems. If you have questions about AIX details, that's fine. But limiting the implementation to Linux is not acceptable. All other ISA and optimization features added to GCC that are supported on all OSes are implemented on all OSes. This tablejump change should be no different. Thanks, David Thanks, David Thanks, David