From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dje.gcc@gmail.com>
Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com
 [IPv6:2607:f8b0:4864:20::92f])
 by sourceware.org (Postfix) with ESMTPS id EFECE3858C2C
 for <gcc-patches@gcc.gnu.org>; Thu, 14 Oct 2021 13:43:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EFECE3858C2C
Received: by mail-ua1-x92f.google.com with SMTP id f3so11353422uap.6
 for <gcc-patches@gcc.gnu.org>; Thu, 14 Oct 2021 06:43:00 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=Hdlv/Tg0GkrfJdqlAL7I0J6QuzygIRvZMIpuc0rxW7s=;
 b=S/AIaPYWSrjx81todtfQInGvBBePG0WVgdb+PIVb92X3O5YjhqbIS6vgaJXANjmD9/
 me+uaAyxDGAU4vZ0weLz7cPPZYB6gVDGb6uUAVE00bH54thvq6wW+G7FPeWyC07FTHxd
 WizFLyf4uuSCHUr7RNIAG2j+WXdNRTyAX4t23dl2ezQlJMs6UTdTTy8Jiji2zUWUftOF
 mbJ41Kvkn+0PBU00BBnPUR6GytPLLj67SFfpfh6bfhg75CBNRs2C8u52+MRNcf6PNJUw
 64DSjhcV1FBGj6l2rW/Om3VkvXpSccrUCzpBU2f7v6DX6TQr9sOxgAKRcJGATgH494GW
 6P8w==
X-Gm-Message-State: AOAM532AZ2FrJLD4+/6b/tQuNiaIqDvS+a5dXSaiKnyx6KNdVO32+T6b
 FomxJkKWIZv/A3aLgzkIjDc+jbc5MxxNd3XVEAc=
X-Google-Smtp-Source: ABdhPJwU/YP/otPhsO18SezP7MbEwqU70p+j4kn9ZH/u6aWf0YYuFC72tDyT+0apUQ+ljS1+wfbGYsgH4E1fHSzz/V0=
X-Received: by 2002:ab0:76c9:: with SMTP id w9mr6157085uaq.125.1634218979755; 
 Thu, 14 Oct 2021 06:42:59 -0700 (PDT)
MIME-Version: 1.0
References: <PA4PR02MB6686AB43F30EF47E591F12E0EAB89@PA4PR02MB6686.eurprd02.prod.outlook.com>
In-Reply-To: <PA4PR02MB6686AB43F30EF47E591F12E0EAB89@PA4PR02MB6686.eurprd02.prod.outlook.com>
From: David Edelsohn <dje.gcc@gmail.com>
Date: Thu, 14 Oct 2021 09:42:48 -0400
Message-ID: <CAGWvnykb+7RtZkbu1v3_DN+z=-_TPER64JS7oVVyBEFtF_OexA@mail.gmail.com>
Subject: Re: [PATCH] aix: ensure reference to __tls_get_addr is in text
 section.
To: "CHIGOT, CLEMENT" <clement.chigot@atos.net>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Oct 2021 13:43:02 -0000

The reference to __tls_get_addr is in the data section.  And the code
just above creates a symbol in the text section referenced from the
data section to ensure the text section is retained.  So this change
doesn't make sense.  You're essentially saying that the data section
is not used, which makes the other code useless to ensure that the
text section is referenced.

Thanks, David

On Thu, Oct 14, 2021 at 3:06 AM CHIGOT, CLEMENT <clement.chigot@atos.net> w=
rote:
>
> The garbage collector of AIX linker might remove the reference to
> __tls_get_addr if it's added inside an unused csect.
>
>
> Cl=C3=A9ment Chigot
> ATOS Bull SAS
> 1 rue de Provence - 38432 =C3=89chirolles - France
>