From: David Edelsohn <dje.gcc@gmail.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>,
HAO CHEN GUI <guihaoc@linux.vent.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
Bill Schmidt <wschmidt@linux.ibm.com>
Subject: Re: [PATCH, rs6000] Add non-relative jump table support for 64bit rs6000
Date: Tue, 28 Jul 2020 12:56:20 -0400 [thread overview]
Message-ID: <CAGWvnykbMR4aUW=bW1Ur+14NH5zc4i4Uig3of6AwkG97-FrfKg@mail.gmail.com> (raw)
In-Reply-To: <ea01565b-fc36-18f7-a846-eb6bed8a5c6d@linux.ibm.com>
On 2020/7/28 下午1:25, HAO CHEN GUI via Gcc-patches wrote:
> Hi,
>
> This patch adds non-relative jump table support for 64bit rs6000. It implements ASM_OUTPUT_ADDR_VEC_ELT and corresponding expansion of jump table instruction for 64bit rs6000. We want to put non-relative jump table in data.rel.ro section for rs6000. So I add a new target hook - TARGET_ASM_SELECT_JUMPTABLE_SECTION to choose which section jump table should be put in. It puts the jump table in data.rel.ro for 64bit rs6000. For other platforms, it calls targetm.asm_out.function_rodata_section, just as before. We want to have an option to use non-relative jump table even when PIC flag is set. So I add a new option - "mforce-nonrelative-jumptables" for rs6000. It enables the feature by default. The option takes effect in target hook - TARGET_ASM_GENERATE_PIC_ADDR_DIFF_VEC.
>
> static bool
> rs6000_gen_pic_addr_diff_vec (void)
> {
> return TARGET_32BIT || !rs6000_force_nonrelative_jumptables;
> }
>
> The attachments are the patch diff file and change log file.
>
> Bootstrapped and tested on powerpc64le-linux-gnu with no regressions. Is this okay for trunk? Any recommendations? Thanks a lot.
It seems that this will break AIX, especially the select section logic.
Thanks, David
next prev parent reply other threads:[~2020-07-28 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 5:25 HAO CHEN GUI
2020-07-28 9:12 ` Kewen.Lin
2020-07-28 16:56 ` David Edelsohn [this message]
2020-07-30 23:42 ` Segher Boessenkool
2020-07-30 5:21 HAO CHEN GUI
2020-07-30 8:35 ` David Edelsohn
2020-07-30 22:40 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnykbMR4aUW=bW1Ur+14NH5zc4i4Uig3of6AwkG97-FrfKg@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.vent.ibm.com \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).