public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	Bill Schmidt <wschmidt@linux.ibm.com>,
	 GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH take #2] PR target/43892: Some carry flag (CA) optimizations on PowerPC.
Date: Tue, 14 Dec 2021 11:17:04 -0500	[thread overview]
Message-ID: <CAGWvnykfDm+QhrGuAi-wA3utNgCWagcgmtxQFefmnZD6erPU4Q@mail.gmail.com> (raw)

Hi, Roger!

Thanks very much for investigating this issue and developing a patch
to leverage this feature of the PowerPC architecture.

2021-12-03  Roger Sayle  <roger@nextmovesoftware.com>

gcc/ChangeLog
        PR target/43892
        * config/rs6000/rs6000.md (*add<mode>3_carry_in_0_2): New
        define_insn to recognize commutative form of add<mode>3_carry_in_0.
        (*add<mode>3_geu, *add<mode>3_leu, *subf<mode>3_carry_in_xx_subf,
        *add<mode>3_carry_in_addc): New define_insn_and_split patterns.

It might be easier to read if each of the define_insn_and_split
ChangeLog entries were on a separate line and the latter ones said
"Same" or "Likewise", but up to you. Segher can be more pedantic.

gcc/testsuite/ChangeLog
        PR target/43892
        * gcc.target/powerpc/addcmp.c: New test case.
        * gcc.target/powerpc/pr43892.c: New test case.

This patch is okay.

Thanks, David

             reply	other threads:[~2021-12-14 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 16:17 David Edelsohn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-12-03 19:42 Roger Sayle
2021-12-15  2:11 ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGWvnykfDm+QhrGuAi-wA3utNgCWagcgmtxQFefmnZD6erPU4Q@mail.gmail.com \
    --to=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=roger@nextmovesoftware.com \
    --cc=segher@kernel.crashing.org \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).