From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dje.gcc@gmail.com>
Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com
 [IPv6:2607:f8b0:4864:20::92c])
 by sourceware.org (Postfix) with ESMTPS id E4B5C3858409
 for <gcc-patches@gcc.gnu.org>; Tue, 14 Dec 2021 16:17:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E4B5C3858409
Received: by mail-ua1-x92c.google.com with SMTP id t13so35696757uad.9
 for <gcc-patches@gcc.gnu.org>; Tue, 14 Dec 2021 08:17:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
 bh=bMD2dNHge7/X779Uzz8avb88bLqWvwjs7FXJh6qK91k=;
 b=vwCMwpZteIGTpApn3mKEGQZRNlqahXa9FeWSZc+jXAZny6H07TAfX2g4POwmr7I1jg
 qfXM3DNBfWNPkLRwa9N6RHNxcgbjIyvG1bd43otoYZ40+P4p31dA85o8qkdWKES3eRo5
 6kSG6K/AdFHjmAbiMZkie9dps1veBDcAHbnwXOu4w7Q3STLv84JAaJH07Jslo/9rBDmL
 PRJkAbY3okKgbpAUtOtTaA+erXoCYV+gL+4dj1rc78GYf6vcNZsEBM80KNz2uXYdIsng
 8vO8lnbNm8FVTtik/C5EqCcknQYv1Rhhfdymj8L/A6xprmtU2tcGSGnGO1jxo5RxPELO
 t5pQ==
X-Gm-Message-State: AOAM5320ALgtdQr8CpP19cT/7op1RM8OTABK/WBRFW6b0lIK1WECDRrf
 s6r8jt3WxJ7BE0UKT7ZzFcaglmuTXqm9vjhIGY4=
X-Google-Smtp-Source: ABdhPJx8DsHVPAAIII4Tw0RtC+JxwuWH83ASrTM4Lea4ePTQYrsUyNHoqfk7QB9gyPhA6Asw/zhNpcFFgyfJIyoNGK4=
X-Received: by 2002:a05:6102:e0f:: with SMTP id
 o15mr5847380vst.51.1639498635410; 
 Tue, 14 Dec 2021 08:17:15 -0800 (PST)
MIME-Version: 1.0
From: David Edelsohn <dje.gcc@gmail.com>
Date: Tue, 14 Dec 2021 11:17:04 -0500
Message-ID: <CAGWvnykfDm+QhrGuAi-wA3utNgCWagcgmtxQFefmnZD6erPU4Q@mail.gmail.com>
Subject: Re: [PATCH take #2] PR target/43892: Some carry flag (CA)
 optimizations on PowerPC.
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
 Bill Schmidt <wschmidt@linux.ibm.com>, 
 GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Dec 2021 16:17:17 -0000

Hi, Roger!

Thanks very much for investigating this issue and developing a patch
to leverage this feature of the PowerPC architecture.

2021-12-03  Roger Sayle  <roger@nextmovesoftware.com>

gcc/ChangeLog
        PR target/43892
        * config/rs6000/rs6000.md (*add<mode>3_carry_in_0_2): New
        define_insn to recognize commutative form of add<mode>3_carry_in_0.
        (*add<mode>3_geu, *add<mode>3_leu, *subf<mode>3_carry_in_xx_subf,
        *add<mode>3_carry_in_addc): New define_insn_and_split patterns.

It might be easier to read if each of the define_insn_and_split
ChangeLog entries were on a separate line and the latter ones said
"Same" or "Likewise", but up to you. Segher can be more pedantic.

gcc/testsuite/ChangeLog
        PR target/43892
        * gcc.target/powerpc/addcmp.c: New test case.
        * gcc.target/powerpc/pr43892.c: New test case.

This patch is okay.

Thanks, David