From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dje.gcc@gmail.com>
Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633])
	by sourceware.org (Postfix) with ESMTPS id 23E8C385354A
	for <gcc-patches@gcc.gnu.org>; Tue,  6 Sep 2022 17:08:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 23E8C385354A
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x633.google.com with SMTP id bj12so24703715ejb.13
        for <gcc-patches@gcc.gnu.org>; Tue, 06 Sep 2022 10:08:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=EyzdaoQql+D8oVJH/EjIGM7FBWOUJgnrhL67QfqeMYk=;
        b=Qy9wQBY3PACZi1sCMiJHtC1Ak7qdcrmKyv/dMhUFvDlp7jZQ6RAIhhK2vUh6dIbvAO
         GEIhyWySF5LA8Aq5QKsC8piwsuLNIWtW5jf5jhk3O4CXlu4mUU/BmN2zwMWCQMgyDXiM
         cOvnCDnXX8fSmojQYTWl6PcNyhHiZvKZyvNo6heaegCKXP6Ih3MMO2bLkaztDDFFDYHI
         SOZ8BGpYYBUq39PdtChlSNZfePz3uLSFxsKMehjm/nQDkI/1MjOuJHI95NFV1vtdxJUL
         u9oic7DbPy3N5yAPJyPgOcUjf6QxoxYVAu/VkIxE75+DTFMZKIecBkDpNv0XdtagctZ0
         wMAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=EyzdaoQql+D8oVJH/EjIGM7FBWOUJgnrhL67QfqeMYk=;
        b=HoY4QdzaJuvHYx/Fpe3t+3wPH+9NpmBjzKRNCMKsS454vYWy4bs2OiDEJO21qM995E
         VPF3VXPIl4wTl/Ts/SzA5HH12lNo9Nkn3LjuG+W7GbxI7FhRsgxcFO1K+abiZDwbhW0j
         GLSohZP1kt0wo69yfqGcKS5eHV6Vk1pi6i3L7JAS242ufaWYk1nmzin3vwj2ZRP4TDuT
         gqVzMLWU+kCOq7FSTU6osx4WNwPGPoTJ1zuo6D8EwwT/24k/w9ynRU7NnLPzcmAIXSst
         /ixMBr7Zv2+lLfOul61a8kGuLWg0atFUOOuo6EXPlHQ1JBFruFVKCQa/vBdLygltnTxP
         UWvA==
X-Gm-Message-State: ACgBeo0VPbNUF6ztGKD4hsXasgatK3VJDIjGdPdXwa785Bhwe9N7FG++
	TzQ422dvBllnE5UFzwwhg9WOnaa+Mk0wtvXp8ndSwH9mLoA=
X-Google-Smtp-Source: AA6agR6NxSAgQlo2ty7NaOfqz4G7A3yRv+CvkLh+DTqJN4mQ6rL1Lr4xNhuMujjPwO1Dzlz4wo9D6SAT5jW0uXgX7/I=
X-Received: by 2002:a17:907:1c87:b0:741:8199:a59d with SMTP id
 nb7-20020a1709071c8700b007418199a59dmr30222681ejc.736.1662483636793; Tue, 06
 Sep 2022 10:00:36 -0700 (PDT)
MIME-Version: 1.0
References: <CAGWvnykbugCTPx7vMd9S-iHPjeohU0xkdQ7Ny_EcpQRTMbsrNA@mail.gmail.com>
In-Reply-To: <CAGWvnykbugCTPx7vMd9S-iHPjeohU0xkdQ7Ny_EcpQRTMbsrNA@mail.gmail.com>
From: David Edelsohn <dje.gcc@gmail.com>
Date: Tue, 6 Sep 2022 13:00:25 -0400
Message-ID: <CAGWvnykp0i-AVyoE5jy-tCayjL0zg1Pgb1p8LvzC6pFSP7bFSA@mail.gmail.com>
Subject: Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality
To: Martin Liska <mliska@suse.cz>, Richard Biener <rguenther@suse.de>, Jeff Law <jeffreyalaw@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: multipart/alternative; boundary="0000000000009db71405e80522b7"
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

--0000000000009db71405e80522b7
Content-Type: text/plain; charset="UTF-8"

	* dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise.
	(HAVE_XCOFF_DWARF_EXTRAS): Likewise.
	(output_fde): Likewise.
	(output_call_frame_info): Likewise.
	(have_macinfo): Likewise.
	(add_AT_loc_list): Likewise.
	(add_AT_view_list): Likewise.
	(output_compilation_unit_header): Likewise.
	(output_pubnames): Likewise.
	(output_aranges): Likewise.
	(output_line_info): Likewise.
	(output_macinfo): Likewise.
	(dwarf2out_finish): Likewise.
	(dwarf2out_early_finish): Likewise.

These changes are not correct and break AIX bootstrap.

Those changes are not related to stabs support.  We agreed to remove stabs and

XCOFF stabs support, not GCC DWARF debugging support for AIX.

Also

	* configure: Regenerate. Likewise.
	* configure.ac: Likewise.

does not list that tests for HAVE_XCOFF_DWARF_EXTRAS was removed, so
the ChangeLog was not accurate.

Again, that test is required for AIX is not part of stabs support.


Please revert this change so that AIX can continue to be bootstrapped
and tested, and we can work together to test a corrected patch.

Thanks, David


On Tue, Sep 6, 2022 at 12:31 PM David Edelsohn <dje.gcc@gmail.com> wrote:

> I fully support the plan to remove stabs support, but this patch broke
> bootstrap on AIX.  It seems rather bad policy to remove support for a
> feature without ensuring that the removal does not negatively impact the
> targets touched by the patch.  I should have been explicitly copied on
> these patches and I should have been asked to test the patches before they
> were installed, if for no other reason than politeness and consideration.
>
> Thanks, David
>
>
>

--0000000000009db71405e80522b7--