From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 5ECA4384D16B for ; Wed, 7 Sep 2022 13:43:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5ECA4384D16B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x633.google.com with SMTP id gb36so30429082ejc.10 for ; Wed, 07 Sep 2022 06:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=hqPHi6TojqH22kD7QttKsRPkZJU8i8eQ2SKRv7GrMMU=; b=BsrKbNjW9n7UWmZcUtrDMmH2z8TbENNp47TyHR7Ip+xuRw4qQ0OT48ifDIFfCHDDIJ qwVIMo70hZ/5o9znXKVnl3g7Ist7SJV3BCnbTLEbpFUirLA9oYi8GNwC+dOgboV7pYX9 wUFKF7WES/ymTZTUTn1/cr8a+4bXcSkMPqSQ03+RLYs57elwZibI7SVQeaM3tcNJI5kL +VP8puASk01IVPn5wTc4FiAiwUaJTpdmTjUYRJw23YmrJ0JwIPrJdpxiQZXGB2YUK3eP takL305IxoB/eAeSQjLVWm0xBiYGAnOSCqC9aiaZOKJ9P2W+3arwASEifwVJR5PKSi3Y fJnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=hqPHi6TojqH22kD7QttKsRPkZJU8i8eQ2SKRv7GrMMU=; b=2YAd3B1MUj71AwKv2fJRH7zQy1lQXfl0Ve9oaQwcdMDnyb5rVWQN6lU7MDPFXqUKb0 zzQ9bv4yhtp2bFxaBUKvwG2JF2jC9R5+urTAH0JwimWfkii1+Gwdj0+fGqcbCWRMESYS IRTOdv/QNmygFI/YUTMg/uh8Mfi5YtleLj8pvFhmI1p+C4gtWDLJzTssFr//KOAcS7fN zZcuFWpxugp9MJuIYe0MDwEu9n5KWWsOMRp8VcDP2vrTctXrkCrH+XRuFWGFV8dJNdup F/p8eDXxz8XpKy4nwDAqY0oMcgTq68KfJHxTRfnaQYkpHLX92F2bCettMj8tDeNQzh8Y zNxg== X-Gm-Message-State: ACgBeo1hVPj+kVJfH+18VgGPozY+lU4nW2qx7DxdL8S+iuH+c0RhIfRp KsbWtpx4zFhxUvwpqnzXfCg0KfhWMobSuDmxAsU= X-Google-Smtp-Source: AA6agR79Q31I7/McqTmKxgunLoHrE2PnAEc9nNMiOy8t2g1v3CDO1jpFqweUJWYayUGCKxAaqzlnSAe+OsKsc0LVQiI= X-Received: by 2002:a17:907:2705:b0:741:6caa:20f4 with SMTP id w5-20020a170907270500b007416caa20f4mr2379946ejk.35.1662558219066; Wed, 07 Sep 2022 06:43:39 -0700 (PDT) MIME-Version: 1.0 References: <3993d3d0-9c4b-1293-07b5-be14a84c2959@suse.cz> In-Reply-To: <3993d3d0-9c4b-1293-07b5-be14a84c2959@suse.cz> From: David Edelsohn Date: Wed, 7 Sep 2022 09:43:26 -0400 Message-ID: Subject: Re: [PATCH] Restore XCOFF for DWARF on AIX. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: GCC Patches , Richard Biener Content-Type: multipart/alternative; boundary="00000000000010eff305e8168037" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000010eff305e8168037 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 7, 2022 at 7:45 AM Martin Li=C5=A1ka wrote: > Hi. > > The patch restores DWARF support for AIX target where XCOFF file container > is used. > Verified before and after the patch, gcc119 machine (AIX) could not build > any run-time library, > now it can. > > Ready to be installed? > Thanks, > Martin > > PR bootstrap/106855 > > gcc/ChangeLog: > > * collect2.cc (scan_prog_file): Restore if XCOFF_DEBUGGING_INFO. > * config/rs6000/rs6000.cc (rs6000_option_override_internal): > Restore usage of XCOFF_DEBUGGING_INFO. > * config/rs6000/xcoff.h (XCOFF_DEBUGGING_INFO): Restore. > * dwarf2asm.cc (XCOFF_DEBUGGING_INFO): Restore support for > XCOFF_DEBUGGING_INFO. > (dw2_asm_output_nstring): Likewise. > (USE_LINKONCE_INDIRECT): Likewise. > * dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise. > (HAVE_XCOFF_DWARF_EXTRAS): Likewise. > (output_fde): Likewise. > (output_call_frame_info): Likewise. > (have_macinfo): Likewise. > (add_AT_loc_list): Likewise. > (add_AT_view_list): Likewise. > (output_compilation_unit_header): Likewise. > (output_pubnames): Likewise. > (output_aranges): Likewise. > (output_line_info): Likewise. > (output_macinfo): Likewise. > (dwarf2out_finish): Likewise. > (dwarf2out_early_finish): Likewise. > Hi, Martin Thanks for the quick patch to fix this. This restores bootstrap, but does not completely restore functionality. This patch did not restore the gcc/configure test for AIX assembler XCOFF feature support that defines HAVE_XCOFF_DWARF_EXTRAS. That part of the removal patch also needs to be reverted. Thanks, David --00000000000010eff305e8168037--