From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id C6CDB3858422; Sat, 16 Dec 2023 21:24:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6CDB3858422 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6CDB3858422 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::634 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702761868; cv=none; b=xD+Ay2LGnhN5BAOMDZMbhTsFO6dQLAZ3nIHFt/z//mloKv1fnGbtaeeH4OBnYTUoEGkzZMfRconuEW5ZxX38EZ2DGbhCaoD87R5KV3NPAJZ+gNaY8bFYG20fFeMOC2/i8FioySiXhRGYt0cPXYPZyUswY+IXP39nsYnw7RDDHu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702761868; c=relaxed/simple; bh=vzxn5zrQasb4S/8MFqlYoOE7XpT0l45H72SPtRyPPh4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ZHLCWFh4REAx12LS5Wxd/uDTtFNOHV9zIEQwzDAtQ9WZOjKoMWimNTSxcSN3qHKbndNd/JmnTfnCPU2ALvqozWZ1AM/wJJXR1lGbfdVEKVk2eFgc8OFMkMRIDPPZufaMvty3ZtQ2r+Xnw9gpVKt3B16kN8Aucgyu0v8iFfhjK58= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a233bf14cafso20852066b.2; Sat, 16 Dec 2023 13:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702761865; x=1703366665; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=79zbAvxNpzLCzlcO+fDewcak7YvLmd7Hz9ieTAPUGeE=; b=FQGDUuvJpNkqhpyM7WbTN0UHYu0YRBKURcQJ4W9UQ/Hu5JvmFxeDiF8Bhr2dj+Xr5c Ei9MUm98J6l5uoviYWLcHxx/4kYHAOKcFQhKHKcEOfyI+LtDyWyKeWpAAyg1LQuiVU0B k8sJnnwNtSOcXESHCLbNNBWxwmKgl+fAv3PSgb+V+w64wDpfbCH3BvSF79/hnOEhuD3e vWLeJPCncDTcbq9V185BPpY7piImQ72G8iWaORYo2i05o/Q5TXQjd9IgAjt0oVT4NctS H25o1kq/dfUCszlH58aaVFu/kpHndtbLnigRGfJqEGKPoPteQaq7Bx7TclLzLpsOB1cK JtkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702761865; x=1703366665; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=79zbAvxNpzLCzlcO+fDewcak7YvLmd7Hz9ieTAPUGeE=; b=pUBbLVCAMIGhKg2YCGIjrKpDWUvZJF7dPj5QlIc9uX4oLRfpQX5/daDg1oTJH1NfS7 FnfVkSzyVkqgSCigwiU701ybWrlzJsNXyIvoCOH5C318xjse+rhFpi1LGNRF6AbP1wVo yaYvkTJxBijrjJes6Z+Jwvy+kuruxuvpKdRVQlOsWrEMp8JygZos8B5uK8dUSVYr4Z9d /xIKb9NeVNpU5hd7PUQpI8TNH2zveN0jKYuaLkdM1BJtFZVtuK5KlqpDpnA6hJkHB/Ic +xowGbvFSKxVAN5xZ022yaMhNdt582Ld4DygX0xptdj+eHc66mTtOrvf4Ki4kr6urVne 8cTA== X-Gm-Message-State: AOJu0YworhlnTY0B4oTm46fKjp0Hxw7m32MyoW/OD95RqjZUNlIkAFC7 rNpvCHWnuKrfM1cgFkdBed9c6Nrs2jMO8Rs1bxTzp4nfNZQ= X-Google-Smtp-Source: AGHT+IEK7KhY2WOeEUJtv6CrCqzhdm+kNr5tfVGItkTK/45/gigtGCHgyFrOinXMeeI/vpC6hPGebsxM5LXjE8Qn/rk= X-Received: by 2002:a17:907:869e:b0:a1e:a:12d2 with SMTP id qa30-20020a170907869e00b00a1e000a12d2mr9580210ejc.77.1702761864779; Sat, 16 Dec 2023 13:24:24 -0800 (PST) MIME-Version: 1.0 From: David Edelsohn Date: Sat, 16 Dec 2023 16:24:13 -0500 Message-ID: Subject: Re: [committed] libstdc++: Implement C++23 header [PR107760] To: Jonathan Wakely Cc: GCC Patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000165b09060ca724bf" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000165b09060ca724bf Content-Type: text/plain; charset="UTF-8" Hi, Jonathan Unfortunately this patch broke bootstrap on AIX. In file included from /tmp/GCC/gcc/include-fixed/wchar.h:64, from /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/cwchar:44, from /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/bits/postypes.h:40, from /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/bits/char_traits.h:42, from /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/string:42, from /nasfarm/edelsohn/src/src/libstdc++-v3/src/c++23/print.cc:26: /nasfarm/edelsohn/src/src/libstdc++-v3/src/c++23/print.cc: In function 'void* std::__open_terminal(FILE*)': /nasfarm/edelsohn/src/src/libstdc++-v3/src/c++23/print.cc:78:24: error: expected id-expression before '(' token 78 | if (int fd = ::fileno(f); fd >= 0 && ::isatty(fd)) | ^~~~~~ make[6]: *** [Makefile:747: print.lo] Error 1 AIX stdio.h defines fileno as a macro although there is a symbol in libc. I think that print.cc at least needs to #undef fileno before the usage. Thanks, David --000000000000165b09060ca724bf--