* [PATCH] Fix pt.c bootstrap breakage
@ 2018-02-27 23:27 David Edelsohn
2018-02-28 10:21 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: David Edelsohn @ 2018-02-27 23:27 UTC (permalink / raw)
To: GCC Patches, Jason Merrill, Jakub Jelinek, Martin Sebor
The recent change to pt.c broke bootstrap by including C++ header file
<string> directly and including it first. This patch changes to the
necessary method which includes the header file via system.h.
Okay?
Thanks, David
* pt.c: Don't include string. Define INCLUDE_STRING before system.h.
Index: pt.c
===================================================================
--- pt.c (revision 258045)
+++ pt.c (working copy)
@@ -24,8 +24,8 @@
all methods must be provided in header files; can't use a source
file that contains only the method templates and "just win". */
-#include <string>
#include "config.h"
+#define INCLUDE_STRING
#include "system.h"
#include "coretypes.h"
#include "cp-tree.h"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix pt.c bootstrap breakage
2018-02-27 23:27 [PATCH] Fix pt.c bootstrap breakage David Edelsohn
@ 2018-02-28 10:21 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2018-02-28 10:21 UTC (permalink / raw)
To: David Edelsohn; +Cc: GCC Patches, Jason Merrill, Jakub Jelinek, Martin Sebor
On Wed, Feb 28, 2018 at 12:27 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> The recent change to pt.c broke bootstrap by including C++ header file
> <string> directly and including it first. This patch changes to the
> necessary method which includes the header file via system.h.
>
> Okay?
Ok. But in reality nobody should use std::string ...
> Thanks, David
>
> * pt.c: Don't include string. Define INCLUDE_STRING before system.h.
>
> Index: pt.c
> ===================================================================
> --- pt.c (revision 258045)
> +++ pt.c (working copy)
> @@ -24,8 +24,8 @@
> all methods must be provided in header files; can't use a source
> file that contains only the method templates and "just win". */
>
> -#include <string>
> #include "config.h"
> +#define INCLUDE_STRING
> #include "system.h"
> #include "coretypes.h"
> #include "cp-tree.h"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-28 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-27 23:27 [PATCH] Fix pt.c bootstrap breakage David Edelsohn
2018-02-28 10:21 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).