From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 8A4813858C52 for ; Fri, 23 Sep 2022 14:11:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A4813858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x530.google.com with SMTP id y8so369676edc.10 for ; Fri, 23 Sep 2022 07:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=HMlVe4HeEzu3iVkOrkAOIvzVbL+y8x81nl/v5sdCdqk=; b=EMdZ0zJtAJLgw/zbWZVzLr3Hba2mzLd6Ue3Ew5YtevnNowlG2LplxBthrTdmQngIq7 iZrIjysxDj0b4vGyTzz5IN4V3TR8nkUxv4Y1eVynT7zdm6eNTqttrat1YrSQKhFwi5I3 OOcjP7To8JPWJAb4Aq99z7uTvXOsficLGmGfra+uC9SZcp3u7jWETCf5NEXOSH9Mk1co NVi2ZD4MdqP0QwEKi4mOmA3tWxz830r/Y8dYD0TjFDfVjz0XZQfsaU7f29dKga8eg/nl z3pu9cHFuiLvb/pEroaEMnEEDOrSSXI8995SXyki3Vce7GBqms3TMOe7JAg/MB5Cg7em j6dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=HMlVe4HeEzu3iVkOrkAOIvzVbL+y8x81nl/v5sdCdqk=; b=uXDgH/mUrCpVrbo1TswKNOFOSEQtkgM+paHZ+Cs7DwBCKxpsAPVYYKE/Fr8DfmMHvM Yi72vh8wdVsbID57wg8BHzNDPRkzgpT0zrdQG8aKj6hH47a7itj9r5ZP7z+oB+CaZFHL VjuiceSKzrcOte5Fe+KCDLjs3Q1iSsWmfeaFKaVXMUId15Vts/HyhMiz4Gh6AeAIhgzx r3+9l+ZKrlYFc2FaNyTbox8PPGRUhWnJ97GHg2uXMQ9eSNVW8VqKq96jqxb6Xq2apPH6 H72yYefOCVSXYNHjJIjhHriH1+rfwdsCxHrZdB5H/Vzoa4oh8AGAMTH0F24d9LlemPfF If1w== X-Gm-Message-State: ACrzQf2jEJuTnvZMcCnYs7Vo+dXsUdJPHyAvVlkBznrviix5Snb84RxE h2+QKl9X7SlhdS3H2RzSrPZuinz7zc0PHD3Y7OU= X-Google-Smtp-Source: AMsMyM6f0X1JKPY8YimcRSXNQw/oVdr1ue4PgHlttzv++eEadDK8K1owD3yHdq1yEEkeKUtjD3EjMsiSv1OZRtuPVtA= X-Received: by 2002:aa7:d785:0:b0:452:dfa2:bb17 with SMTP id s5-20020aa7d785000000b00452dfa2bb17mr8571549edq.407.1663942315268; Fri, 23 Sep 2022 07:11:55 -0700 (PDT) MIME-Version: 1.0 References: <88e489d8-4248-75de-6e8e-af6f152da61b@in.tum.de> In-Reply-To: <88e489d8-4248-75de-6e8e-af6f152da61b@in.tum.de> From: David Edelsohn Date: Fri, 23 Sep 2022 10:11:36 -0400 Message-ID: Subject: Re: [PATCH] Avoid depending on destructor order To: Thomas Neumann Cc: Jason Merrill , GCC Patches Content-Type: multipart/alternative; boundary="000000000000a0e31705e958c248" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000a0e31705e958c248 Content-Type: text/plain; charset="UTF-8" On Fri, Sep 23, 2022 at 9:38 AM Thomas Neumann wrote: > > This patch broke bootstrap on AIX and probably other targets. > > > > #ifdef ATOMIC_FDE_FAST_PATH > > #include "unwind-dw2-btree.h" > > > > static struct btree registered_frames; > > static bool in_shutdown; > > ... > > #else > > > > in_shutdown only is defined for ATOMIC_FDE_FAST_PATH but used in code / > > asserts not protected by that macro. > > > > gcc_assert (in_shutdown || ob); > > return (void *) ob; > > } > > I am sorry for that, I did not consider that my test machines all use > the fast path. > > I think the problem can be fixed by the trivial patch below, I will > commit that after I have tested builds both with and without fast path. > > Best > > Thomas > > > diff --git a/libgcc/unwind-dw2-fde.c b/libgcc/unwind-dw2-fde.c > index d237179f4ea..d6e347c5481 100644 > --- a/libgcc/unwind-dw2-fde.c > +++ b/libgcc/unwind-dw2-fde.c > @@ -67,6 +67,8 @@ static void > init_object (struct object *ob); > > #else > +/* Without fast path frame lookup must always succeed */ > +static const bool in_shutdown = false; > > /* The unseen_objects list contains objects that have been registered > but not yet categorized in any way. The seen_objects list has had > I tried the patch but it still failed because the type name "bool" is not known. This patch is the only use of "bool" in the libgcc source code, which is C, not C++. Thanks, David --000000000000a0e31705e958c248--