From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15602 invoked by alias); 31 Jul 2013 16:00:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15580 invoked by uid 89); 31 Jul 2013 16:00:02 -0000 X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-ve0-f172.google.com) (209.85.128.172) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 31 Jul 2013 16:00:01 +0000 Received: by mail-ve0-f172.google.com with SMTP id oz10so1000395veb.3 for ; Wed, 31 Jul 2013 08:59:54 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.58.234.161 with SMTP id uf1mr28506745vec.57.1375286394189; Wed, 31 Jul 2013 08:59:54 -0700 (PDT) Received: by 10.220.53.132 with HTTP; Wed, 31 Jul 2013 08:59:54 -0700 (PDT) In-Reply-To: <20130729183927.GA11877@ibm-tiger.the-meissners.org> References: <20130520204053.GA21090@ibm-tiger.the-meissners.org> <20130522205258.GA11470@ibm-tiger.the-meissners.org> <20130729183927.GA11877@ibm-tiger.the-meissners.org> Date: Wed, 31 Jul 2013 16:00:00 -0000 Message-ID: Subject: Re: [PATCH, rs6000] power8 patches, revised patch #8, power8 load fusion From: David Edelsohn To: Michael Meissner , GCC Patches , Pat Haugen , Peter Bergner Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-07/txt/msg01557.txt.bz2 On Mon, Jul 29, 2013 at 2:39 PM, Michael Meissner wrote: > This is the revised version of my patch #8 for power8 support. I have removed > all of the incidental changes, and only added the support for load fusion. I > have added support for fusion on 32-bit Linux. I have added a test to make > sure the fusion ops are being generated. In emit_fusion_gpr_load(), please add else gcc_unreachable (); to the if (TARGET_ELF) ... else if (TARGET_XCOFF) ... paths. Those really should be unreachable and not fall into the "Could not generate addis value for fusion" fatal error. Okay with that change. Thanks, David