From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id F06EC3858C98; Sun, 17 Dec 2023 00:15:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F06EC3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F06EC3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702772149; cv=none; b=RQa2HKXAJ3npy5GYaFTQD+6aGF2kXBFKEeSiUGa/nZCe8waoj0eBuOKEfhfoRl+EKAkGUDk4XuBMeOBx/cjA+/XlFPmeLTydKZ9F6UU6k2h9C9obZddeRk8GoynPK2a7lDXAxpG2NxcqPSJR4ks/hm+I6ZHu5GJ5M9Ib6w8KwEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702772149; c=relaxed/simple; bh=DOmfizrfCBOu2TOUc83cCTclNBNM5YExI4cjUTD666Y=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=CXUqJtnin7p3YIt+h6Tp9mqIGMHbfy50oCQFxPY7lsyRLXiWW7hBc4I3JThEFUw94oFe3Yh8PdLjwi7e6Mo3x5BeOBrApMJ7NoR+2uRLxfWR2qfkvIe5laLocQ2U+JJbzoELCadltjslf697FAXB07E/ImlEwgx9Nw5OKx7tNLU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-553338313a0so39124a12.2; Sat, 16 Dec 2023 16:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702772146; x=1703376946; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DOmfizrfCBOu2TOUc83cCTclNBNM5YExI4cjUTD666Y=; b=NHDziQAKtTKe2ASTLV6DwDc6gIJew4obdmA0S+GMDiGiJNLOgSeBgFpSd7Z3hgECsO tC++eGmjILe/zKxzHUQku5CNgm1ReqOfW190sUlCRH4KYYsX2ciPel9Hwt3RgRFVXI5a JiaEq425RJSiQlClPWBETpzEAdti2Of4zlnkjk0xKGDgrsWylYsrX/iiwEHUZerPtQI8 wEEVfcKm873jcEYbg6zwhtrU8kO/h7v6WnaGNqJi0kTWcl1uYqbNkrqRQ8wTTmNN0E5p 7C7mCpSpxlRLqX5AkD/B4VwHka5KazlFiAW2ZLBVBcdw7mpZK3eiTgj12WV03XkbX7nS rs4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702772146; x=1703376946; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DOmfizrfCBOu2TOUc83cCTclNBNM5YExI4cjUTD666Y=; b=Ce7x0bHhRXyx2r+wDlMWrZ8prOghoWXFjYyTRAHQ7s+GBkXlyfqIt5sfoZpcJ8cwwK Ev1RCXAb4kQar1KsN2LtHW8w/CZAhBXoUYr2MAygi85WfxXFQsYegOIhQZAxptNTQbcM iMjHUJLt9SD7j3/Ymu9zKPMxWieTKx5yGXS/VGJerRCkY4Kr7m7RDuqF+diBMG6j/Ufz zbNoKdaWKeEdqKiW6ixhtZTnooSpfK4/mu8y91qftc5rvVmdVoQ0/ir8Yfc87aFc8Eh9 Ys8TVls1XpczgVjLYzbyWOHONASOOaIPHkxLxFJSd8YEpdWBIPjPn6piQc21I1Axfb4o 8Hnw== X-Gm-Message-State: AOJu0YwTp84YGoHqVeDTjvtHZrNqCuALxuBsAlcL9Kqr9af4NC45dT3M /VGeBnpmHNyT41087HwOIe/dBN/EFAa22q4KxHU= X-Google-Smtp-Source: AGHT+IE8l1sZF67mPjbx78VhLTnrNmWo74g0H37G5q9TLMpPXbQ7hSB1xkyUG8Wh+T20tpeTgMf+bNx54D3Tf4OIAaU= X-Received: by 2002:a50:cb87:0:b0:54d:9782:c3d9 with SMTP id k7-20020a50cb87000000b0054d9782c3d9mr7240422edi.8.1702772146439; Sat, 16 Dec 2023 16:15:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Edelsohn Date: Sat, 16 Dec 2023 19:15:34 -0500 Message-ID: Subject: Re: [committed] libstdc++: Implement C++23 header [PR107760] To: Jonathan Wakely Cc: Jakub Jelinek , GCC Patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000ec099f060ca988a2" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ec099f060ca988a2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 16, 2023 at 7:04=E2=80=AFPM Jonathan Wakely wrote: > On Sun, 17 Dec 2023 at 00:02, Jonathan Wakely wrote: > > > > On Sat, 16 Dec 2023 at 23:06, David Edelsohn wrote: > > > > > > On Sat, Dec 16, 2023 at 4:44=E2=80=AFPM Jakub Jelinek > wrote: > > >> > > >> On Sat, Dec 16, 2023 at 04:24:13PM -0500, David Edelsohn wrote: > > >> > AIX stdio.h defines fileno as a macro although there is a symbol in > libc. > > >> > > > >> > I think that print.cc at least needs to > > >> > > > >> > > > >> > #undef fileno > > >> > > > >> > > > >> > before the usage. > > >> > > >> Or (::fileno)(f) ? > > > > > > > > > Yes, that also avoids the error. > > > > Yup, I've just tested it. I'll push that change in the morning. > > Actually I just pushed it now. The functions in that file are only > actually used on Windows, so if they build on linux and AIX, that's > good enough. > Thanks. I had tested and was just about to push it myself. Thanks, David --000000000000ec099f060ca988a2--