From: David Edelsohn <dje.gcc@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Joel Brobecker <brobecker@adacore.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>
Subject: Re: add powerpc_vsx_ok requirement to undef-bool tests
Date: Fri, 26 Feb 2021 12:32:16 -0500 [thread overview]
Message-ID: <CAGWvnymTYHxa2qGkNtx-=SfKtbMwq4Gr8VYw7hftGxY9G=HwYw@mail.gmail.com> (raw)
In-Reply-To: <or5z2ex0um.fsf@lxoliva.fsfla.org>
On Fri, Feb 26, 2021 at 11:14 AM Alexandre Oliva <oliva@adacore.com> wrote:
>
> These tests use -mvsx in their dg-options list, so they are only
> applicable if the -mvsx option is supported by the compiler.
>
> Tested with target ppc64-vx7r2, configured to force altivec disabled,
> and thus to reject vsx. Ok to install?
This patch is okay.
Thanks, David
>
>
> From: Joel Brobecker <brobecker@adacore.com>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/powerpc/undef-bool-2.c: Add
> dg-require-effective-target powerpc_vsx_ok directive.
> * g++.dg/ext/undef-bool-1.C: Add dg-require-effective-target
> powerpc_vsx_ok directive.
> ---
> gcc/testsuite/g++.dg/ext/undef-bool-1.C | 1 +
> gcc/testsuite/gcc.target/powerpc/undef-bool-2.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/g++.dg/ext/undef-bool-1.C b/gcc/testsuite/g++.dg/ext/undef-bool-1.C
> index 716e06c1ce413..9cc1cd8726098 100644
> --- a/gcc/testsuite/g++.dg/ext/undef-bool-1.C
> +++ b/gcc/testsuite/g++.dg/ext/undef-bool-1.C
> @@ -1,6 +1,7 @@
> /* { dg-do compile { target { powerpc*-*-* } } } */
> /* { dg-options "-O2 -DNO_WARN_X86_INTRINSICS -mvsx" } */
> /* { dg-require-effective-target lp64 } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
>
> /* Test to ensure that "bool" gets undef'd in xmmintrin.h when
> we require strict ANSI. */
> diff --git a/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c b/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
> index d4944ab1ca6c7..7bc5d18484039 100644
> --- a/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
> +++ b/gcc/testsuite/gcc.target/powerpc/undef-bool-2.c
> @@ -1,6 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-O2 -std=c11 -DNO_WARN_X86_INTRINSICS -mvsx" } */
> /* { dg-require-effective-target lp64 } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
>
> /* Test to ensure that "bool" gets undef'd in xmmintrin.h when
> we require strict ANSI. Subsequent use of bool needs stdbool.h.
>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
next prev parent reply other threads:[~2021-02-26 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:14 Alexandre Oliva
2021-02-26 17:32 ` David Edelsohn [this message]
2021-03-09 3:18 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnymTYHxa2qGkNtx-=SfKtbMwq4Gr8VYw7hftGxY9G=HwYw@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=brobecker@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=oliva@adacore.com \
--cc=ro@cebitec.uni-bielefeld.de \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).