public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, rs6000] Fix PR67489
@ 2016-01-21 23:00 Bill Schmidt
  2016-01-21 23:22 ` David Edelsohn
  0 siblings, 1 reply; 2+ messages in thread
From: Bill Schmidt @ 2016-01-21 23:00 UTC (permalink / raw)
  To: gcc-patches; +Cc: dje.gcc

Hi,

The test case gcc.target/powerpc/p8vector-builtin-8.c needs to be
restricted to targets that support the __int128 keyword.  This was
wrongly being attempted with { dg-do compile { target int128 } } when
what's really wanted is { dg-require-effective-target int128 }.  With
this patch, the test no longer runs on 32-bit targets.

Tested on powerpc64-unknown-linux-gnu using -m32.  Is this ok for trunk?

Thanks,
Bill


2016-01-21  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	PR testsuite/67489
	* gcc.target/powerpc/p8vector-builtin-8.c: Remove { target int128
	} from dg-do compile directive, and instead add {
	dg-require-effective-target int128 }.


Index: gcc/testsuite/gcc.target/powerpc/p8vector-builtin-8.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/p8vector-builtin-8.c	(revision 232683)
+++ gcc/testsuite/gcc.target/powerpc/p8vector-builtin-8.c	(working copy)
@@ -1,5 +1,6 @@
-/* { dg-do compile { target int128 } } */
+/* { dg-do compile } */
 /* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target int128 } */
 /* { dg-options "-mpower8-vector -O2" } */
 
 #include <altivec.h>


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, rs6000] Fix PR67489
  2016-01-21 23:00 [PATCH, rs6000] Fix PR67489 Bill Schmidt
@ 2016-01-21 23:22 ` David Edelsohn
  0 siblings, 0 replies; 2+ messages in thread
From: David Edelsohn @ 2016-01-21 23:22 UTC (permalink / raw)
  To: Bill Schmidt; +Cc: GCC Patches

On Thu, Jan 21, 2016 at 6:00 PM, Bill Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:
> Hi,
>
> The test case gcc.target/powerpc/p8vector-builtin-8.c needs to be
> restricted to targets that support the __int128 keyword.  This was
> wrongly being attempted with { dg-do compile { target int128 } } when
> what's really wanted is { dg-require-effective-target int128 }.  With
> this patch, the test no longer runs on 32-bit targets.
>
> Tested on powerpc64-unknown-linux-gnu using -m32.  Is this ok for trunk?
>
> Thanks,
> Bill
>
>
> 2016-01-21  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
>
>         PR testsuite/67489
>         * gcc.target/powerpc/p8vector-builtin-8.c: Remove { target int128
>         } from dg-do compile directive, and instead add {
>         dg-require-effective-target int128 }.

Okay.

Thanks, David

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-21 23:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-21 23:00 [PATCH, rs6000] Fix PR67489 Bill Schmidt
2016-01-21 23:22 ` David Edelsohn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).