From: David Edelsohn <dje.gcc@gmail.com>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
Bill Schmidt <wschmidt@linux.ibm.com>,
"Carl E. Love" <cel@us.ibm.com>
Subject: Re: [PATCH, rs6000] punish reload of lfiwzx when loading an int variable [PR102169, PR102146]
Date: Wed, 13 Oct 2021 11:21:22 -0400 [thread overview]
Message-ID: <CAGWvnyms1tH5yteA4rRscysV_Qf8+WnNPAMQg87UrfEVLGc9XQ@mail.gmail.com> (raw)
> The patch punishes reload of alternative pair of "d, Z" for movsi_internal1. The reload occurs if 'Z' doesn't match and generates an additional insn. So the memory reload should be punished.
>
> Bootstrapped and tested on powerpc64le-linux with no regressions. Is this okay for trunk? Any recommendations? Thanks a lot.
>
>
> ChangeLog
>
> 2021-09-29 Haochen Gui <guihaoc@linux.ibm.com>
>
> gcc/
> * gcc/config/rs6000/rs6000.md (movsi_internal1): disparages
> slightly the alternative 'Z' of "lfiwzx" when reload is needed.
Capitalize "D" of disparages.
Should this disparage "stfiwzx" also? Carl Love saw poor code
generation at -O0 for a trivial example where a stack store moved the
value to an FPR and used stfiwx.
Thanks, David
next reply other threads:[~2021-10-13 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 15:21 David Edelsohn [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-29 8:32 HAO CHEN GUI
2021-10-14 0:12 ` Segher Boessenkool
2021-10-14 8:37 ` HAO CHEN GUI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnyms1tH5yteA4rRscysV_Qf8+WnNPAMQg87UrfEVLGc9XQ@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=cel@us.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).