From: David Edelsohn <dje.gcc@gmail.com>
To: Edmar Wienskoski <edmarwjr@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)
Date: Mon, 17 Jun 2013 23:37:00 -0000 [thread overview]
Message-ID: <CAGWvnymtHH=W8XGx6Sq3e7Ar=24n4DORnus-wp1ustoXTMAkLw@mail.gmail.com> (raw)
In-Reply-To: <20130613153701.GI21523@bubble.grove.modra.org>
On Thu, Jun 13, 2013 at 11:37 AM, Alan Modra <amodra@gmail.com> wrote:
> Revised patch with offsettable_ok_by_alignment change, avoiding dumb
> idea of using statement expressions. This one actually bootstraps and
> passes regression testing.
>
> * config/rs6000/rs6000.h (enum data_align): New.
> (LOCAL_ALIGNMENT, DATA_ALIGNMENT): Use rs6000_data_alignment.
> (DATA_ABI_ALIGNMENT): Define.
> (CONSTANT_ALIGNMENT): Correct comment.
> * config/rs6000/rs6000-protos.h (rs6000_data_alignment): Declare.
> * config/rs6000/rs6000.c (rs6000_data_alignment): New function.
The revised patch, without the DECL_P part is okay.
The original code produced the necessary alignment and neither of us
can find any code in public packages that increases the alignment for
PPC vector types. While there is the possibility that a user could
encounter an object file produced by an older GCC with less strict
alignment and a version of GCC with this fix would make an incorrect
assumption, this does not seem very likely in practice.
Thanks, David
next prev parent reply other threads:[~2013-06-17 23:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 19:26 Jakub Jelinek
2013-06-07 20:43 ` Richard Henderson
2013-06-07 21:14 ` Jakub Jelinek
2013-06-08 15:13 ` Jakub Jelinek
2013-06-10 14:52 ` Richard Henderson
2013-06-10 15:45 ` Jakub Jelinek
2013-06-10 19:44 ` David Edelsohn
2013-06-11 0:44 ` DJ Delorie
2013-06-11 6:06 ` Jakub Jelinek
2013-06-11 15:20 ` DJ Delorie
2013-06-07 22:56 ` Hans-Peter Nilsson
2013-06-08 15:05 ` Jakub Jelinek
2013-06-10 10:51 ` Bernd Schmidt
2013-06-10 10:56 ` Jakub Jelinek
2013-06-10 11:03 ` Bernd Schmidt
2013-06-10 11:52 ` Ulrich Weigand
2013-06-12 17:52 ` Edmar Wienskoski
2013-06-13 7:41 ` Alan Modra
2013-06-13 15:37 ` Alan Modra
2013-06-13 15:42 ` Jakub Jelinek
2013-06-13 22:48 ` Alan Modra
2013-06-14 9:00 ` Jakub Jelinek
2013-06-14 10:42 ` Alan Modra
2013-06-14 10:54 ` Jakub Jelinek
2013-06-14 14:57 ` Alan Modra
2013-06-17 23:37 ` David Edelsohn [this message]
[not found] ` <0EFAB2BDD0F67E4FB6CCC8B9F87D75692B5204DB@IRSMSX101.ger.corp.intel.com>
2013-06-19 7:02 ` FW: " Igor Zamyatin
2013-06-19 7:05 ` Jakub Jelinek
2013-06-19 7:12 Igor Zamyatin
2013-06-19 7:22 ` Jakub Jelinek
2013-06-19 8:38 ` Richard Biener
2013-06-19 8:44 ` Jakub Jelinek
2013-06-19 16:32 ` Mike Stump
2013-06-19 16:25 ` Mike Stump
2013-06-19 19:27 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnymtHH=W8XGx6Sq3e7Ar=24n4DORnus-wp1ustoXTMAkLw@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=amodra@gmail.com \
--cc=edmarwjr@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).