From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95806 invoked by alias); 4 Dec 2015 14:46:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95788 invoked by uid 89); 4 Dec 2015 14:46:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f180.google.com Received: from mail-lb0-f180.google.com (HELO mail-lb0-f180.google.com) (209.85.217.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 04 Dec 2015 14:46:01 +0000 Received: by lbbed20 with SMTP id ed20so7374217lbb.2 for ; Fri, 04 Dec 2015 06:45:58 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.112.150.135 with SMTP id ui7mr7296045lbb.53.1449240358353; Fri, 04 Dec 2015 06:45:58 -0800 (PST) Received: by 10.114.62.230 with HTTP; Fri, 4 Dec 2015 06:45:58 -0800 (PST) In-Reply-To: <2c10dc4d733427f3f85b219f8b9a49e3f5034bdd.1449238455.git.segher@kernel.crashing.org> References: <2c10dc4d733427f3f85b219f8b9a49e3f5034bdd.1449238455.git.segher@kernel.crashing.org> Date: Fri, 04 Dec 2015 14:46:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] rs6000: Clean up the cstore code a bit From: David Edelsohn To: Segher Boessenkool Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-12/txt/msg00574.txt.bz2 On Fri, Dec 4, 2015 at 9:34 AM, Segher Boessenkool wrote: > "register_operand" was a bit confusing. Also some other minor cleanups. > > Tested on powerpc64-linux; okay for mainline? > > > Segher > > > 2015-12-04 Segher Boessenkool > > * (cstore4_unsigned): Use gpc_reg_operand instead of > register_operand. Remove empty constraints. Use std::swap. > (cstore_si_as_di, cstore4_signed_imm, > cstore4_unsigned_imm, cstore4 for GPR): Use > gpc_reg_operand instead of register_operand. > (cstore4 for FP): Use gpc_reg_operand instead of > register_operand. Remove empty constraints. Okay. Thanks, David