From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68835 invoked by alias); 23 Aug 2018 12:53:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68813 invoked by uid 89); 23 Aug 2018 12:53:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:56ef051, H*i:sk:56ef051, H*c:alternative, five X-HELO: mail-wr1-f46.google.com Received: from mail-wr1-f46.google.com (HELO mail-wr1-f46.google.com) (209.85.221.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Aug 2018 12:53:05 +0000 Received: by mail-wr1-f46.google.com with SMTP id m27-v6so4561030wrf.3; Thu, 23 Aug 2018 05:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cMzkDoaYn7qsm9diEkbp+B1yRlSkxZiumWJBMAH6hSY=; b=Gx6/eksXCgQ2A377BnhuloxULP6GPO4yf3k3X5kbW2dzFzKFiQpJl8mPrNuW99EMWQ qxs/M/1GsMBZg9U2rescVJCfXVqhhJYiFyJVZ+qnNfxo2xox2nMMS3xhzXp2GOCm1B6f s2CiETBMjN6DaXml4Ba8Ipjaq+jNvqcVCqjbNaQzL/ibLTv92T9Big0JeralVQpaQEz7 LDwLYcHrUsduaN4z1Mbm78LLWjTMemyIU0hHXocagWr2knTkD926lXOzGg0fC+4g+4bw WReNu0DNywmV+Hxy5g4B6tZhotNsNlw3Km2rIPr0YWZgXjqjhNeynrPoMfmGWB91lhT1 cqxA== MIME-Version: 1.0 References: <20180726133142.DE075D801C7@oc3748833570.ibm.com> <01cd923e-18c7-f745-a75d-49536d56cdbf@netcologne.de> <5B6021C0.5060507@arm.com> <20180802113135.5qmwnfpxwv4dic6z@student.ethz.ch> <20180802170441.aidlg6grthuavogc@student.ethz.ch> <805d5eb8-c014-223e-0590-cd0e1eadb739@netcologne.de> <1ad32961-9592-348a-c055-934b8269aa0c@netcologne.de> <56ef051c-d2d6-3d95-f623-4d20248102ba@netcologne.de> In-Reply-To: <56ef051c-d2d6-3d95-f623-4d20248102ba@netcologne.de> From: David Edelsohn Date: Thu, 23 Aug 2018 12:53:00 -0000 Message-ID: Subject: Re: Async I/O patch with compilation fix To: Thomas Koenig Cc: Christophe Lyon , Decius Caecilius Metellus , "Andre Vieira (lists)" , GCC Patches , Fortran List , Ulrich Weigand , clyon@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-08/txt/msg01465.txt.bz2 Thomas, Once the plural.c file has been re-generated incorrectly using the local Yacc, it must be deleted and checked out again. Did you pull it fresh from the repository in your AIX tree after the incorrect checkout? Thanks, David On Wed, Aug 22, 2018 at 5:30 PM Thomas Koenig wrote: > Hi David, > > > This patch broke bootstrap on AIX again. This is completely > unacceptable. > > Again, sorry for the breakage. > > I faced quite some challenges trying to get bootstrap to > work on gcc119. Despite quite a few e-mails (plus hints in a PR) > that I received, none of the hints for bootstrap I got actually got > it to work. I finally gave up after four or five different failures, > and the patch was committed because every test > that _could_ be run did show no failure. > > Had we received instructions that work for bootstrapping on AIX, > we would have tested the patch there. > > If it were possible to add instructions that do work for AIX > bootstrapping to the compile farm wiki, that would be great. > > If you (or somebody else who has the requisite AIX fu) could test > patches that are known to be difficult, that would also be > great. > > As long as we have no other solution, it is probably best to #ifdef out > AIX any additional pthread-related functionality for libgfortran that > might be coming along. That can always be integrated later, if somebody > can re-implement POSIX condition variables for libgfortran from what > AIX provides. > > Let's talk about how to proceed at the GNU cauldron, over a beer. > Both Nicolas and I will be there. > > In the meantime, I have committed the following patch (r263788) as > obvious after regression-testing on Linux both with ASYNC_IO set > to 1 and to 0. Let me know how that works out. > > 2018-08-22 Thomas Koenig > > * async.h: Set ASYNC_IO to zero if _AIX is defined. > (struct adv_cond): If ASYNC_IO is zero, the struct has no members. > (async_unit): If ASYNC_IO is zero, remove unneeded members. > > 2018-08-22 Thomas Koenig > > * gfortran.texi: Mention that asynchronous I/O does > not work on systems which lack condition variables, such > as AIX. > > Regards > > Thomas >