From: David Edelsohn <dje.gcc@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 5/5] rs6000: Do not allow TImode with -m32 -mpowerpc64
Date: Thu, 15 Jan 2015 16:18:00 -0000 [thread overview]
Message-ID: <CAGWvnyn2ksx+cdH4kTBc0w8Bd+ty0hMiJSP=6vM_EvkyMY1D1Q@mail.gmail.com> (raw)
In-Reply-To: <687b2e40d388708e5b7604b1fcc1ce7e4b127b5b.1421282067.git.segher@kernel.crashing.org>
On Wed, Jan 14, 2015 at 8:14 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> This fixes 141 FAILs.
>
> -mpowerpc64 does not change the ABI, but default_scalar_mode_supported_p
> does not know that, and allows TImode for -m32 -mpowerpc64.
>
> This fixes it. Okay for mainline?
>
>
> 2015-01-14 Segher Boessenkool <segher@kernel.crashing.org>
>
> gcc/
> * config/rs6000/rs6000.c (rs6000_scalar_mode_supported_p): Disallow
> TImode for TARGET_32BIT.
Okay.
Would you please add a comment that efficient TImode arithmetic
requires carry to explain the TARGET_32BIT relationship?
We can think about providing TImode logical operations in 32 bit, in
the long run.
Thanks, David
next prev parent reply other threads:[~2015-01-15 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 1:19 [PATCH 1/5] rs6000: Fix PROMOTE_MODE for " Segher Boessenkool
2015-01-15 1:47 ` [PATCH 3/5] rs6000: Fix va_start handling for -m32 -mpowerpc64 ABI_V4 Segher Boessenkool
2015-01-15 4:53 ` David Edelsohn
2015-01-15 3:51 ` [PATCH 2/5] rs6000: Fix TARGET_PROMOTE_FUNCTION_MODE Segher Boessenkool
2015-01-15 4:43 ` David Edelsohn
2015-01-15 4:36 ` [PATCH 4/5] rs6000: Introducing rs6000_abi_word_mode Segher Boessenkool
2015-01-15 5:00 ` David Edelsohn
2015-01-15 4:37 ` [PATCH 5/5] rs6000: Do not allow TImode with -m32 -mpowerpc64 Segher Boessenkool
2015-01-15 16:18 ` David Edelsohn [this message]
2015-01-16 16:58 ` Segher Boessenkool
2015-01-15 4:39 ` [PATCH 1/5] rs6000: Fix PROMOTE_MODE for " David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnyn2ksx+cdH4kTBc0w8Bd+ty0hMiJSP=6vM_EvkyMY1D1Q@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).